🐛 fix(IntegerRing.from_number): Use less dubious implementation.

Author: make-github-pseudonymous-again

src/IntegerRing.js

@@ -2,6 +2,7 @@ import { Integer } from './' ;
 import { DEFAULT_DISPLAY_BASE } from './' ;
 import { parse , convert } from '@aureooms/js-integer-big-endian' ;
 import { TypeError , ValueError } from '@aureooms/js-error' ;
+import { _from_number } from './_from_number' ;
 
 export class IntegerRing {
 
@@ -49,14 +50,11 @@ export class IntegerRing {
 
 	from_number ( number , is_negative = 0 ) {
 
-		if ( number < 0 ) {
-			is_negative = ~is_negative ;
-			number = -number ;
-		}
+		const dirty = _from_number(number) ;
 
-		const limbs = convert( 0x20000000000000 , this.base , [ number ] , 0 , 1 ) ;
+		const limbs = dirty._limbs_in_base(this.base) ;
 
-		return new Integer( this.base , is_negative , limbs ) ;
+		return new Integer( this.base , is_negative ^ dirty.is_negative , limbs ) ;
 
 	}
 

test/src/ZZ/from.js

@@ -1,6 +1,6 @@
 import test from 'ava' ;
 
-import { ZZ , ValueError , TypeError } from '../../../src' ;
+import { ZZ , ValueError , TypeError , MIN_NUMBER , MAX_NUMBER } from '../../../src' ;
 
 test( 'ZZ.from()' , t => {
 
@@ -20,6 +20,9 @@ test( 'ZZ.from()' , t => {
 
 	t.is( ZZ.from( [ 0 , 1 ] ).toString() , ZZ.base.toString() ) ;
 
+	t.is( MAX_NUMBER.toString() , ZZ.from(MAX_NUMBER).toString() ) ;
+	t.is( MIN_NUMBER.toString() , ZZ.from(MIN_NUMBER).toString() ) ;
+
 	t.is( ZZ.from(ZZ.from(2, undefined, -1).pow(12)).toString(), '4096')
 	t.is( ZZ.from(ZZ.from(2, undefined, 0).pow(12)).toString(), '4096')
 	t.is( ZZ.from(ZZ.from(2, undefined, -1).pow(11)).toString(), '-2048')