Skip to content

makeup-menu-button: Docs mention non-existent custom events #219

@backflip

Description

@backflip

The component docs mention a makeup-menu-button-select and a makeup-menu-button-change custom event: https://github.com/makeup/makeup-js/tree/master/packages/ui/makeup-menu-button

However, the code is not dispatching any of these: https://github.com/makeup/makeup-js/blob/master/packages/ui/makeup-menu-button/src/index.js

We are currently using instance.menu.el.addEventListener("makeup-menu-select") instead.

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions