MultiSig - Propose to change on the overrides logic process

[githubckgoh1439]

Hi, YK

While come to Create-multisig-Tx and Sign-multisig-Tx in those test-cases, I will set this :

let overrides = {
    accountNumber: multiSigWallet.multisigAccountState.value.accountNumber,
    nonce: 0           
}

So, I will base on this below :

// Removing multisig signature elements, so that it will be using wallet signature instead of multisig.
if (overrides && overrides["accountNumber"]) {
   delete overrides["accountNumber"];
   if (!silent) console.log(indent, "\nsendRawTransaction()........delete overrides[accountNumber]");
}
if (overrides && overrides["nonce"]) {
   delete overrides["nonce"];
   if (!silent) console.log(indent, "\nsendRawTransaction()........delete overrides[nonce]");
}

And change to this below :

// Removing multisig signature elements, so that it will be using wallet signature instead of multisig.
if (overrides && overrides["accountNumber"]) {
   delete overrides["accountNumber"];
   delete overrides["nonce"];
}

Because while I do debugging it always skip this selection 'if (overrides && overrides["nonce"])', even I set like this :

let overrides = {
    accountNumber: multiSigWallet.multisigAccountState.value.accountNumber,
    nonce: 0           
}

Any comments ?

[b00f]

Your change look a bit dangerous. Because you try to override the nonce even it is not requested.

Because while I do debugging it always skip this selection 'if (overrides && overrides["nonce"])', even I set like this :

The reason might be you set nonce to zero: nonce: 0

changing
if (overrides && overrides["nonce"]) {
to
if (overrides && overrides["nonce"] !== null) {
will fix your issue.

The !== check both value and type. In this case 0 !=== null.

[githubckgoh1439]

Hi, Mostafa TQ for the comments, I take note on this. Hi, YK Any comments base on this ?

…

On Mon, May 4, 2020 at 2:02 PM Mostafa Sedaghat Joo < ***@***.***> wrote: Your change look a bit dangerous. Because you try to override the nonce even it is not requested. Because while I do debugging it always skip this selection 'if (overrides && overrides["nonce"])', even I set like this : The reason might be you set nonce to zero: nonce: 0 changing if (overrides && overrides["nonce"]) { to if (overrides && overrides["nonce"] !== null) { will fix your issue. The !== check both value and type. In this case 0 !=== null. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#25 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIQPD6BAYIQX6WQXPVCAST3RPZK6PANCNFSM4MYMY2LQ> .