From 92912deb35b94fbbb63144218e49e9a9dba904f3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Paul=20S=C3=BCtterlin?= Date: Wed, 17 Jun 2026 16:06:08 +0000 Subject: [PATCH] fix: log correctly if session key is not available. Right now, a missing session key may result in the following stacktrace ``` File "/opt/netbox/venv/lib/python3.12/site-packages/netbox_config_diff/compliance/base.py", line 166, in get_devices_with_rendered_configs self.check_netbox_secrets() File "/opt/netbox/venv/lib/python3.12/site-packages/netbox_config_diff/compliance/secrets.py", line 94, in check_netbox_secrets self.get_master_key() File "/opt/netbox/venv/lib/python3.12/site-packages/netbox_config_diff/compliance/secrets.py", line 39, in get_master_key if getattr(self.logger, "log_failure"): ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ AttributeError: 'Logger' object has no attribute 'log_failure' ``` --- netbox_config_diff/compliance/secrets.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/netbox_config_diff/compliance/secrets.py b/netbox_config_diff/compliance/secrets.py index b41c079..571390d 100644 --- a/netbox_config_diff/compliance/secrets.py +++ b/netbox_config_diff/compliance/secrets.py @@ -34,8 +34,8 @@ def get_master_key(self) -> None: sk = SessionKey.objects.get(userkey__user=self.request.user) self.master_key = sk.get_master_key(self.session_key) except Exception as e: - if getattr(self, "logger"): - if getattr(self.logger, "log_failure"): + if hasattr(self, "logger"): + if hasattr(self.logger, "log_failure"): self.logger.log_failure(f"Can't fetch master_key: {str(e)}") else: self.logger.error(f"Can't fetch master_key: {str(e)}")