From a120a86a9cf2c9e900d773f18e8ed4feb4e9e236 Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Tue, 30 Sep 2025 09:22:21 -0700 Subject: [PATCH 1/2] chore: use relative path in the comment for the baseURL Othewise it may cause confusion if the user puts something like https://demo.playwright.dev/todomvc/#/ in the base url and wants to navigate to that exact url by default. --- assets/playwright.config.js | 2 +- assets/playwright.config.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/assets/playwright.config.js b/assets/playwright.config.js index 11b4e9c..447ef54 100644 --- a/assets/playwright.config.js +++ b/assets/playwright.config.js @@ -26,7 +26,7 @@ export default defineConfig({ reporter: 'html', /* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */ use: { - /* Base URL to use in actions like `await page.goto('/')`. */ + /* Base URL to use in actions like `await page.goto('./')`. */ // baseURL: 'http://localhost:3000', /* Collect trace when retrying the failed test. See https://playwright.dev/docs/trace-viewer */ diff --git a/assets/playwright.config.ts b/assets/playwright.config.ts index 57b2c3c..e2f2f18 100644 --- a/assets/playwright.config.ts +++ b/assets/playwright.config.ts @@ -25,7 +25,7 @@ export default defineConfig({ reporter: 'html', /* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */ use: { - /* Base URL to use in actions like `await page.goto('/')`. */ + /* Base URL to use in actions like `await page.goto('./')`. */ // baseURL: 'http://localhost:3000', /* Collect trace when retrying the failed test. See https://playwright.dev/docs/trace-viewer */ From 33a2f708e27e00a422804c83a482843d795a3047 Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Tue, 30 Sep 2025 09:53:35 -0700 Subject: [PATCH 2/2] use empty string --- assets/playwright.config.js | 2 +- assets/playwright.config.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/assets/playwright.config.js b/assets/playwright.config.js index 447ef54..0913c45 100644 --- a/assets/playwright.config.js +++ b/assets/playwright.config.js @@ -26,7 +26,7 @@ export default defineConfig({ reporter: 'html', /* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */ use: { - /* Base URL to use in actions like `await page.goto('./')`. */ + /* Base URL to use in actions like `await page.goto('')`. */ // baseURL: 'http://localhost:3000', /* Collect trace when retrying the failed test. See https://playwright.dev/docs/trace-viewer */ diff --git a/assets/playwright.config.ts b/assets/playwright.config.ts index e2f2f18..80b5a8d 100644 --- a/assets/playwright.config.ts +++ b/assets/playwright.config.ts @@ -25,7 +25,7 @@ export default defineConfig({ reporter: 'html', /* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */ use: { - /* Base URL to use in actions like `await page.goto('./')`. */ + /* Base URL to use in actions like `await page.goto('')`. */ // baseURL: 'http://localhost:3000', /* Collect trace when retrying the failed test. See https://playwright.dev/docs/trace-viewer */