Updated dependencies and cleaned code#4
Open
javiermarinros wants to merge 4 commits into
Open
Conversation
added 4 commits
May 8, 2025 10:54
chore: replace symfony/http-client with guzzlehttp/guzzle chore: add phpstan support and fix phpstan issues
refactor: remove old-syntax arrays
There was a problem hiding this comment.
Pull Request Overview
This PR updates dependencies and cleans code by bumping the PHP version to 8.2, updating the Symfony HTTP client version, adding support for PhpStan static analysis, and refactoring various code sections to use modern PHP syntax.
- Updated static analysis configuration with PhpStan.
- Refactored string concatenation to interpolation and updated array syntax.
- Bumped PHP and dependency versions in composer.json and updated documentation.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| phpstan.neon | Adds a PhpStan configuration file with analysis parameters. |
| lib/Service/UpdateService.php | Refactors HTTP request URL construction and updates parameter type hints. |
| lib/Service/ProfileService.php | Standardizes URL interpolation for HTTP requests. |
| lib/Model/Update.php | Updates array syntax and adjusts docblocks to acknowledge nullable types. |
| lib/Model/Schedule.php | Refactors constructors and array initializations with modern syntax. |
| lib/Http/Client.php | Simplifies the HTTP client method by directly returning the response array. |
| lib/Auth/AuthorizationTokenInterface.php | Adds a return type hint for the access token. |
| lib/Auth/AuthorizationToken.php | Makes minor docblock adjustments. |
| composer.json | Bumps PHP version, updates Symfony HTTP client version, and adds PhpStan to dev requirements. |
| README.md | Updates PHP version prerequisite in the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumped required minimum PHP version to 8.2
Added support for PhpStan static analysis and fixed the found issues