Skip to content

Updated dependencies and cleaned code#4

Open
javiermarinros wants to merge 4 commits into
miguelbemartin:masterfrom
javiermarinros:php84-fixes
Open

Updated dependencies and cleaned code#4
javiermarinros wants to merge 4 commits into
miguelbemartin:masterfrom
javiermarinros:php84-fixes

Conversation

@javiermarinros
Copy link
Copy Markdown
Collaborator

Bumped required minimum PHP version to 8.2
Added support for PhpStan static analysis and fixed the found issues

Javier Marín added 4 commits May 8, 2025 10:54
chore: replace symfony/http-client with guzzlehttp/guzzle
chore: add phpstan support and fix phpstan issues
refactor: remove old-syntax arrays
@javiermarinros javiermarinros requested a review from Copilot May 8, 2025 13:25
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates dependencies and cleans code by bumping the PHP version to 8.2, updating the Symfony HTTP client version, adding support for PhpStan static analysis, and refactoring various code sections to use modern PHP syntax.

  • Updated static analysis configuration with PhpStan.
  • Refactored string concatenation to interpolation and updated array syntax.
  • Bumped PHP and dependency versions in composer.json and updated documentation.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
phpstan.neon Adds a PhpStan configuration file with analysis parameters.
lib/Service/UpdateService.php Refactors HTTP request URL construction and updates parameter type hints.
lib/Service/ProfileService.php Standardizes URL interpolation for HTTP requests.
lib/Model/Update.php Updates array syntax and adjusts docblocks to acknowledge nullable types.
lib/Model/Schedule.php Refactors constructors and array initializations with modern syntax.
lib/Http/Client.php Simplifies the HTTP client method by directly returning the response array.
lib/Auth/AuthorizationTokenInterface.php Adds a return type hint for the access token.
lib/Auth/AuthorizationToken.php Makes minor docblock adjustments.
composer.json Bumps PHP version, updates Symfony HTTP client version, and adds PhpStan to dev requirements.
README.md Updates PHP version prerequisite in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants