GitHub importer uses group's `name` instead of `login`

[Gabriel-Darbord]

We get an error when trying to import the model of a group which has a display name that differs from its login.
For example, the group Evref-BL has the login "Evref-BL" but the name "Evref - Berger-Levrault":
GET https://api.github.com/orgs/Evref-BL ->

{
  "login": "Evref-BL",
  "name": "Evref - Berger-Levrault"
}

The importer tries to use the name when querying the API and we're hit with a 404 Not Found.

GithubModelImporter new
    glhModel: GLHModel new;
    importGroup: 'Evref-BL'.

The issue happens when the name is given in GithubModelImporter>>#importRepositoriesOfGroup:.
However, it seems the login is not stored in the model at all. See the GLHGroup entity below:

Fix

I see three possibilities:

1. GLHGroup's name becomes the login and we discard the display name
2. GLHGroup's name becomes the login and we add a displayName attribute
3. GLHGroup's name stays the display name and we add a login attribute

[badetitou]

I think we used name because it is convenient with Moose. And it is still nice to use it.
The good would have been to use the id for the request (since what we want is to use unique id). It looks like a login is an id in GitHub.
I think we have a similar issue on BitBucket platform for projects.

I would go for option 2. for now. But I do not have super strong args for that

[Gabriel-Darbord]

login is absolutely the same as id, I just used this name because that's what the API uses, but id is the most generic concept reusable in different software forges.
For which fix to choose, I think:

• 1 and 2 are easier than 3 because we don't have to change senders of GLHGroup's name.
• 2 is better than 1 because we have more informations.

So if we agree on 2, I can propose a PR :)