From df55ecf8535362465e0d4f36c8f5d59857df4e83 Mon Sep 17 00:00:00 2001 From: Cristofer Gonzales Date: Mon, 4 Nov 2019 14:58:17 -0300 Subject: [PATCH 1/3] Update cookies modules to enable support for sameSite=none --- package.json | 2 +- test/all-test.js | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/package.json b/package.json index 2061f08..ec1a2ce 100644 --- a/package.json +++ b/package.json @@ -8,7 +8,7 @@ "url" : "https://github.com/mozilla/node-client-sessions" }, "dependencies" : { - "cookies" : "^0.7.0" + "cookies" : "^0.8.0" }, "devDependencies": { "vows": "0.8.1", diff --git a/test/all-test.js b/test/all-test.js index 36b3d30..50763b3 100644 --- a/test/all-test.js +++ b/test/all-test.js @@ -1049,7 +1049,7 @@ suite.addBatch({ var browser = createBrowser(app); browser.get('/bar', { - headers: { 'Cookie': firstHijack + '; ' + secondHijack } + headers: { 'Cookie': firstHijack + '; ' + secondHijack } }, function(res, $){ browser.done(); }); @@ -1296,7 +1296,7 @@ suite.addBatch({ secret: 'yo', activeDuration: 0, cookie: { - sameSite: 'lax' + sameSite: 'none' } })); @@ -1312,7 +1312,7 @@ suite.addBatch({ }); }, "has samesite attribute": function(err, res) { - assert.match(res.headers['set-cookie'][0], /samesite=lax/, "cookie uses samesite"); + assert.match(res.headers['set-cookie'][0], /samesite=none/, "cookie uses samesite"); } } }); From 09741e02501a5133bb87723282600fcd14d344eb Mon Sep 17 00:00:00 2001 From: Cristofer Gonzales Date: Mon, 4 Nov 2019 14:58:40 -0300 Subject: [PATCH 2/3] Adds node version 8 and 10 to travis --- .travis.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.travis.yml b/.travis.yml index 7408e5b..6db3afd 100644 --- a/.travis.yml +++ b/.travis.yml @@ -2,4 +2,6 @@ language: node_js node_js: - "4" - "6" + - "8" + - "10" - stable From 14ac073a12192a615a24d400cd7871a45c940b85 Mon Sep 17 00:00:00 2001 From: Cristofer Gonzales Date: Mon, 4 Nov 2019 15:06:01 -0300 Subject: [PATCH 3/3] Update vow module --- package.json | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/package.json b/package.json index ec1a2ce..9905485 100644 --- a/package.json +++ b/package.json @@ -1,25 +1,25 @@ { - "name" : "client-sessions", - "version" : "0.8.0", - "description" : "secure sessions stored in cookies", - "main" : "lib/client-sessions", - "repository" : { - "type" : "git", - "url" : "https://github.com/mozilla/node-client-sessions" + "name": "client-sessions", + "version": "0.8.0", + "description": "secure sessions stored in cookies", + "main": "lib/client-sessions", + "repository": { + "type": "git", + "url": "https://github.com/mozilla/node-client-sessions" }, - "dependencies" : { - "cookies" : "^0.8.0" + "dependencies": { + "cookies": "^0.8.0" }, "devDependencies": { - "vows": "0.8.1", + "vows": "0.8.3", "express": "4.15.2", "request": "2.81.0" }, - "author" : { - "name" : "Ben Adida", - "email" : "ben@adida.net" + "author": { + "name": "Ben Adida", + "email": "ben@adida.net" }, - "scripts" : { + "scripts": { "test": "vows --spec" }, "engines": {