Skip to content

Inconsistency in HEX data characters in LocoNetEtherBuffer example #50

@fmcopaco

Description

@fmcopaco

hi,

I found an inconsistency in using HEX data characters in LocoNetEtherBuffer example.

When receiving, it decodes HEX data in uppercase ASCII (A-F) like in the examples of The LoconetOverTcp protocol (https://loconetovertcp.sourceforge.net/Protocol/LoconetOverTcp.html).

But, when sending it uses lowercase ASCII (a-f) using digitMap array for conversion:

const char digitMap[] = "0123456789abcdef";

It could lead to communications error if other device expects uppercase as stated in the LoconetOverTcp protocol.

The proposed change for conversion array will be:

const char digitMap[] = "0123456789ABCDEF";

regards,

Paco

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions