add loop target fields and localization for loop functionality#112
add loop target fields and localization for loop functionality#112hugou74130 wants to merge 3 commits into
Conversation
FramePerfection
left a comment
There was a problem hiding this comment.
It would be nice to see which inputs invoke loops in the input list at a glance, and when a looping input is selected, it'd be nice to mark its loop target in the input list as well somehow (e.g. with a blue frame or something).
I can try my hand at that myself if you can't get around to it though.
There was a problem hiding this comment.
It appears that this icon is the cycle from google's Material Symbols library.
https://fonts.google.com/icons?selected=Material+Symbols+Outlined:cycle:FILL@0;wght@400;GRAD@0;opsz@24&icon.query=arrow&icon.set=Material+Symbols&icon.size=24&icon.color=%23e3e3e3
As this is licensed under Apache 2.0, the license needs to be added to the repository and distributions for this file specifically.
FramePerfection requested in review that the loop/loop_light icons (cycle from Google Material Symbols) carry a license notice. Refs: PR mupen64#114 review comment
This pull request enhances the semantic workflow loop input controls by improving user feedback, localization, and internal state tracking. The main focus is to provide better UI cues and ensure changes to loop settings are accurately detected and handled. Additionally, it introduces new localized strings for loop targets and cleans up some debug output.
Loop input control improvements:
controls_for_loopfunction now returns a boolean indicating if any changes were made, ensuring that updates to the loop state (such as toggling, count changes, or target selection) are tracked and trigger appropriate UI updates. [1] [2] [3] [4]Localization:
en_US.lua) and French (fr_FR.lua). [1] [2] [3]UI and icon updates:
loopicon for use in the UI.Code cleanup:
@FramePerfection