Zap cannot inspect sub-resource resource_collections

[lamont-granquist]

See chef/chef#3956 for some discussion

Running the nested-ubuntu-1604 TK test in the iptables cookbook shows an example of the failure:

chef-cookbooks/iptables#37 (comment)

All that zap 'sees' is the iptables_rule resource that is called in the outermost recipe context, the two resources that are created in the nested and the doubly_nested sub-resources are omitted.

Also note that if this bug gets fixed it would simplify zap's use case, since then all zap has to search for is a file or template resource in /etc/iptables.d -- since iptables_rule uses a template resource to place files in there, if zap can descend into sub-resource-collections then it picks that up automatically and there's no need to inject the wrapping resource type into the klass array in zap. The fact that you have to do that is symptomatic of a bug.

[lamont-granquist]

I suspect that fixing this would also bring along a fix for #34 automatically as well (apt_repository and yum_repository in core-chef internally use file and template providers in a use_inline_resources sub-context).

[kplimack]

I am also seeing this bug. When I have a custom_resource create a file from template, that template resource is missing from the resource collection and ends up getting zapped.

[romerojunior]

I'm also affected by this bug when using resource zap_directoy in wrapper cookbooks.