[compatability] Vampiric Glove does not work with Malum's weapons

[Clover9787]

The vampiric glove does not trigger its life-steal effect when using any weapons from the Malum mod. It works perfectly fine with vanilla swords and weapons from other mods, but Malum's weapons seem to be ignored by the glove's logic.
I have also reported this to the Malum team here:
Minecraft 1.21.1
artifacts-neoforge-13.2.1
malum-1.21.1-1.8.2
NeoForge 21.1.227

[ochotonida]

I can't reproduce this issue myself. Could you provide some more information that could help with reproducing the issue, like specific weapons you've tried or any other mods you're using? (Reliquified Artifacts in particular makes a lot of changes to Artifacts, issues you encounter while playing with it should be reported to them instead)

Also, keep in mind that the vampiric glove only applies its life-steal effect to melee attacks. Ranged attacks should be unaffected.

[Clover9787]

I can't reproduce this issue myself. Could you provide some more information that could help with reproducing the issue, like specific weapons you've tried or any other mods you're using? (Reliquified Artifacts in particular makes a lot of changes to Artifacts, issues you encounter while playing with it should be reported to them instead)

Also, keep in mind that the vampiric glove only applies its life-steal effect to melee attacks. Ranged attacks should be unaffected.

After re-testing, I confirmed that this issue only exists with scythe type weapons from the Malum mod. Scythes fail to trigger the lifesteal effect when using melee attacks. I previously suspected it was due to the magic damage dealt by Malum weapons,I apologize for the confusion.The issue persists even after isolating the mod from my larger modpack. And I am not using the "Reliquified Artifacts" mod. Thank you for your reply.

[ochotonida]

It's probably an issue on my end then. The vampiric glove only affects attacks with the player_attack, mob_attack and mob_attack_no_aggro damage types. The same goes for the fire gauntlet and withered bracelet. I didn't test the scythes, but they likely have their own damage type.

I've already changed this to a damage type tag for the next 26.1 update (and added the spear and mace_smash damage types), I'll definitely backport this to 1.21.1 and add the scythe's damage type at some point.

[Clover9787]

Thank you so much for looking into this!By the way, I noticed that the fire gauntlet and withered bracelet actually work fine with the scythes,it’s only the vampic glove that fails to trigger.

[ochotonida]

That's weird. I'll have to look into this a bit further to see what's up