Unmarshaling enters infinite loop if the length field is zero.

[kastork]

When sending PDU's constructed in open-dis python, the length field is zero. During unmarshalling in open-dis-java, an infinite loop is entered because the buffer read pointer is never advanced to the end of the first pdu in the UDP packet.

A pdu with zero in the length field should be detected as invalid and handled accordingly.

[leif81]

Thank-you for the report @kastork . That's a great test case that uses the different language implementations.

Would you be interested in submitting a pull request to fix this?

[kastork]

Yes, could be a while though.

[danielshenry]

my colleague has a fix for this, can i open a branch?
FYI, this was a big problem for us circa 2015-2016, we have used a custom
jar this fixes this issue.
i am not sure how to open a branch for this project,
the fix is pretty simple,
i guess there are only two branches to choose from other than master, but i'm not sure this mixes with the other branches.

[leif81]

@danielshenry what you'll need to do is click the fork button on this project. And then commit your proposed changes to the fork in your users profile. And then when ready open a pull request to propose contributing the change.

For more info you can see this Github docs page : https://docs.github.com/en/pull-requests/collaborating-with-pull-requests