Rename `otel.instrumentation.experimental.span-suppression-strategy`

[zeitlinger]

Rename otel.instrumentation.experimental.span-suppression-strategy to otel.instrumentation.common.experimental.span-suppression-strategy to follow common naming conventions.

This will allow us to clean up

opentelemetry-java-instrumentation/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/InstrumenterBuilder.java

Lines 370 to 382 in c9d0e19

	SpanSuppressor buildSpanSuppressor() {
	// otel.instrumentation.experimental.* doesn't fit the usual pattern of configuration properties
	// for instrumentations, so we need to handle both declarative and non-declarative configs here
	String value =
	ConfigPropertiesUtil.isDeclarativeConfig(openTelemetry)
	? ConfigPropertiesUtil.getString(
	openTelemetry, "common", "span_suppression_strategy/development")
	.orElse(null)
	: ConfigPropertiesUtil.getString(
	"otel.instrumentation.experimental.span-suppression-strategy");
	return new SpanSuppressors.ByContextKey(
	SpanSuppressionStrategy.fromConfig(value).create(getSpanKeysFromAttributesExtractors()));
	}

[laurit]

I think you don't need to wait until 3.0 to start working on this. You could use https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/javaagent-extension-api/src/main/java/io/opentelemetry/javaagent/bootstrap/internal/DeprecatedConfigProperties.java for transitioning to the name.

[zeitlinger]

It's a different interface - and we'd have to add it to instrumentation-api, but I like the idea for giving an early warning.

[Abhilash-Garapati]

This change renames the configuration key:
otel.instrumentation.experimental.span-suppression-strategy TO otel.instrumentation.common.experimental.span-suppression-strategy
as discussed in issue #15566, and adds backward-compatibility support.

Details

1. Updated all internal references to the new config key.
2. Added fallback to the old key, including a warning when the deprecated key is used.
3. Added DeprecatedConfigProperties to instrumentation-api (following the suggested module pattern).
4. Ran spotlessApply for formatting.
5. Verified the build locally.

Please let me know if any further adjustments are needed.