LogDetectiveKojiTriggerHelper is constructing invalid URL for Log Detective

[jpodivin]

What happened? What is the problem?

The helper uses top level Koji task to construct the URL. Whereas logs are available only for children tasks.

What did you expect to happen?

URL should point to actual build logs.

Example URL(s)

No response

Steps to reproduce

1.Have a koji build fail.
2. Observe how Log Detective fails to get the log.
3.

What is the impacted category (job)?

Other

Workaround

• There is an existing workaround that can be used until this issue is fixed.

Participation

• I am willing to submit a pull request for this issue. (Packit team is happy to help!)

[lbarcziova]

What needs to be done here:

1. Pass failed subtask IDs through the event model - In the parser, filter buildArch children with state == 5 (FAILED) and propagate as through KojiEvent
2. Loop over failed subtasks in LogDetectiveKojiTriggerHelper - Instead of using the parent task ID, iterate over the failed subtasks' IDs, sending a separate Log Detective /analyze request for each.
3. Create LogDetectiveRunGroupModel before the loop - One group per failed build (1:1 with KojiBuildTargetModel), with a LogDetectiveRunModel per failed subtask (1:N).