From 4d95c4f6bf53a12c1611cebc54f4d192fef770ec Mon Sep 17 00:00:00 2001 From: Marcelo Romulo Fernandes Date: Tue, 2 May 2023 14:03:55 +0000 Subject: [PATCH 1/3] configure sonar properties at pom.xml --- pom.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pom.xml b/pom.xml index 8122a32..81056aa 100644 --- a/pom.xml +++ b/pom.xml @@ -21,6 +21,9 @@ 5.0.5 5.0.0 1.1.3 + + persapiens + https://sonarcloud.io From de6265c978ffae715f9bbc7e4233ac2ac3c17de5 Mon Sep 17 00:00:00 2001 From: Marcelo Romulo Fernandes Date: Tue, 2 May 2023 14:04:57 +0000 Subject: [PATCH 2/3] remove commented code identified by sonar --- pom.xml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/pom.xml b/pom.xml index 81056aa..9131dd4 100644 --- a/pom.xml +++ b/pom.xml @@ -98,13 +98,6 @@ org.springframework.boot spring-boot-starter-web - org.hsqldb hsqldb From fefa4ac6d72957ea578fbc90c7daff3936512d38 Mon Sep 17 00:00:00 2001 From: Marcelo Romulo Fernandes Date: Tue, 2 May 2023 14:07:20 +0000 Subject: [PATCH 3/3] remode diamond operator issue reported by sonar --- src/main/java/br/edu/ifrn/conta/visao/crud/CrudMBean.java | 2 +- src/main/java/br/edu/ifrn/conta/visao/options/Options.java | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/br/edu/ifrn/conta/visao/crud/CrudMBean.java b/src/main/java/br/edu/ifrn/conta/visao/crud/CrudMBean.java index fdce252..3a9d852 100644 --- a/src/main/java/br/edu/ifrn/conta/visao/crud/CrudMBean.java +++ b/src/main/java/br/edu/ifrn/conta/visao/crud/CrudMBean.java @@ -264,7 +264,7 @@ public final String updateAction(String visualizationMode) { } } if (indexOfBean > -1) { - List newBeanList = new ArrayList(); + List newBeanList = new ArrayList<>(); newBeanList.addAll(this.beanList.subList(0, indexOfBean)); newBeanList.add(updateBean); newBeanList.addAll(this.beanList.subList(indexOfBean + 1, this.beanList.size())); diff --git a/src/main/java/br/edu/ifrn/conta/visao/options/Options.java b/src/main/java/br/edu/ifrn/conta/visao/options/Options.java index 34de01d..bc6bdcf 100644 --- a/src/main/java/br/edu/ifrn/conta/visao/options/Options.java +++ b/src/main/java/br/edu/ifrn/conta/visao/options/Options.java @@ -109,7 +109,7 @@ public final List getList() { private List options; protected final List createOptions() { - List result = new ArrayList(); + List result = new ArrayList<>(); for (T e : this.list) { Object key = key(e); result.add(new SelectItem(key, label(e))); @@ -126,7 +126,7 @@ public final List getOptions() { private List emptyOptions; protected final List createEmptyOptions(List options) { - List result = new ArrayList(options.size() + 1); + List result = new ArrayList<>(options.size() + 1); result.add(new SelectItem("", "", "")); result.addAll(options); return result;