From d2fd004f37c461c5424f82a0e13819598d10c725 Mon Sep 17 00:00:00 2001 From: Peter Hodge Date: Sun, 3 May 2026 08:22:33 +1000 Subject: [PATCH 1/7] ***check versiond emo --- .github/workflows/automated-tests.yaml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/workflows/automated-tests.yaml b/.github/workflows/automated-tests.yaml index 9e22524..c9717a1 100644 --- a/.github/workflows/automated-tests.yaml +++ b/.github/workflows/automated-tests.yaml @@ -25,3 +25,13 @@ jobs: - run: uv run mypy homely test # also verify homely will run on latest python - run: uv run mypy --python-version=3.14 homely test + CheckVersionsDemo: + runs-on: ubuntu-latest + steps: + - name: Checkout + uses: actions/checkout@v2 + - name: Set up Python + uses: actions/setup-python@v5 + with: + python-version: "3.x" + - run: sh bin/ci/check_versions.sh "0.23.1" From c6d16c0fc6f64a86c9ff3919b142621489c0b877 Mon Sep 17 00:00:00 2001 From: Peter Hodge Date: Sun, 3 May 2026 08:24:53 +1000 Subject: [PATCH 2/7] ***bin/ci/check_versions.sh: many debug --- bin/ci/check_versions.sh | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/bin/ci/check_versions.sh b/bin/ci/check_versions.sh index 979c8b6..da9fe3c 100755 --- a/bin/ci/check_versions.sh +++ b/bin/ci/check_versions.sh @@ -12,7 +12,15 @@ expected_version="$1" shift if [ -n "$expected_version" ]; then - if ! grep "^version = \"$expected_version\"" homely/__init__.py &>/dev/null; then + echo '----------' + cat homely/__init__.py + echo '----------' + grep "^version = \"$expected_version\"" homely/__init__.py + echo $? + echo '----------' + if grep "^version = \"$expected_version\"" homely/__init__.py &>/dev/null; then + echo "GOOD: version in homely/__init__.py matches expected version '$expected_version'" + else echo "ERROR: expected 'version = \"$expected_version\"' in homely/__init__.py" >&2 exit 3 fi From 404bccf2380b5e2cc1753ab1469d4316870eea94 Mon Sep 17 00:00:00 2001 From: Peter Hodge Date: Sun, 3 May 2026 08:26:00 +1000 Subject: [PATCH 3/7] ***why logic bad? --- bin/ci/check_versions.sh | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/bin/ci/check_versions.sh b/bin/ci/check_versions.sh index da9fe3c..765a1b8 100755 --- a/bin/ci/check_versions.sh +++ b/bin/ci/check_versions.sh @@ -18,9 +18,7 @@ if [ -n "$expected_version" ]; then grep "^version = \"$expected_version\"" homely/__init__.py echo $? echo '----------' - if grep "^version = \"$expected_version\"" homely/__init__.py &>/dev/null; then - echo "GOOD: version in homely/__init__.py matches expected version '$expected_version'" - else + if ! grep "^version = \"$expected_version\"" homely/__init__.py &>/dev/null; then echo "ERROR: expected 'version = \"$expected_version\"' in homely/__init__.py" >&2 exit 3 fi From 3284b32055f5fb69341255bd8138bfd312dfbc61 Mon Sep 17 00:00:00 2001 From: Peter Hodge Date: Sun, 3 May 2026 08:28:29 +1000 Subject: [PATCH 4/7] ***bring back GOOD --- bin/ci/check_versions.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bin/ci/check_versions.sh b/bin/ci/check_versions.sh index 765a1b8..da9fe3c 100755 --- a/bin/ci/check_versions.sh +++ b/bin/ci/check_versions.sh @@ -18,7 +18,9 @@ if [ -n "$expected_version" ]; then grep "^version = \"$expected_version\"" homely/__init__.py echo $? echo '----------' - if ! grep "^version = \"$expected_version\"" homely/__init__.py &>/dev/null; then + if grep "^version = \"$expected_version\"" homely/__init__.py &>/dev/null; then + echo "GOOD: version in homely/__init__.py matches expected version '$expected_version'" + else echo "ERROR: expected 'version = \"$expected_version\"' in homely/__init__.py" >&2 exit 3 fi From 8411898157b3b02e5ed9c1cb0295c2ee79c2d7cb Mon Sep 17 00:00:00 2001 From: Peter Hodge Date: Sun, 3 May 2026 08:32:37 +1000 Subject: [PATCH 5/7] ***rewrite from Claude --- bin/ci/check_versions.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/bin/ci/check_versions.sh b/bin/ci/check_versions.sh index da9fe3c..0b639b3 100755 --- a/bin/ci/check_versions.sh +++ b/bin/ci/check_versions.sh @@ -18,10 +18,10 @@ if [ -n "$expected_version" ]; then grep "^version = \"$expected_version\"" homely/__init__.py echo $? echo '----------' - if grep "^version = \"$expected_version\"" homely/__init__.py &>/dev/null; then - echo "GOOD: version in homely/__init__.py matches expected version '$expected_version'" - else + if ! grep "^version = \"$expected_version\"" homely/__init__.py &>/dev/null; then echo "ERROR: expected 'version = \"$expected_version\"' in homely/__init__.py" >&2 exit 3 + else + echo "OK: version in homely/__init__.py matches expected version '$expected_version'" fi fi From 6473758642690a4b859306cb50df086f75ed0585 Mon Sep 17 00:00:00 2001 From: Peter Hodge Date: Sun, 3 May 2026 08:34:20 +1000 Subject: [PATCH 6/7] ***get rid of redirect --- bin/ci/check_versions.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/ci/check_versions.sh b/bin/ci/check_versions.sh index 0b639b3..d46f8a7 100755 --- a/bin/ci/check_versions.sh +++ b/bin/ci/check_versions.sh @@ -18,7 +18,7 @@ if [ -n "$expected_version" ]; then grep "^version = \"$expected_version\"" homely/__init__.py echo $? echo '----------' - if ! grep "^version = \"$expected_version\"" homely/__init__.py &>/dev/null; then + if ! grep "^version = \"$expected_version\"" homely/__init__.py; then echo "ERROR: expected 'version = \"$expected_version\"' in homely/__init__.py" >&2 exit 3 else From 44ea8e28dc2a982fa5f79f1ba69c329471d71ea3 Mon Sep 17 00:00:00 2001 From: Peter Hodge Date: Sun, 3 May 2026 08:39:04 +1000 Subject: [PATCH 7/7] ***bin/ci/check_versions.sh: bring back simple redirect --- bin/ci/check_versions.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/ci/check_versions.sh b/bin/ci/check_versions.sh index d46f8a7..c8ac74e 100755 --- a/bin/ci/check_versions.sh +++ b/bin/ci/check_versions.sh @@ -18,7 +18,7 @@ if [ -n "$expected_version" ]; then grep "^version = \"$expected_version\"" homely/__init__.py echo $? echo '----------' - if ! grep "^version = \"$expected_version\"" homely/__init__.py; then + if ! grep "^version = \"$expected_version\"" homely/__init__.py >/dev/null; then echo "ERROR: expected 'version = \"$expected_version\"' in homely/__init__.py" >&2 exit 3 else