diff --git a/codecs/vp8_packet.go b/codecs/vp8_packet.go index 8538098..59b1bc3 100644 --- a/codecs/vp8_packet.go +++ b/codecs/vp8_packet.go @@ -163,14 +163,14 @@ func (p *VP8Packet) Unmarshal(payload []byte) ([]byte, error) { //nolint:gocogni if payloadIndex >= payloadLen { return nil, errShortPacket } - if payload[payloadIndex]&0x80 > 0 { // M == 1, PID is 16bit + if payload[payloadIndex]&0x80 > 0 { // M == 1, PID is 16bit //nolint:gosec // bounds checked above if payloadIndex+1 >= payloadLen { return nil, errShortPacket } - p.PictureID = (uint16(payload[payloadIndex]&0x7F) << 8) | uint16(payload[payloadIndex+1]) + p.PictureID = (uint16(payload[payloadIndex]&0x7F) << 8) | uint16(payload[payloadIndex+1]) //nolint:gosec // bounds checked above payloadIndex += 2 } else { - p.PictureID = uint16(payload[payloadIndex]) + p.PictureID = uint16(payload[payloadIndex]) //nolint:gosec // bounds checked above payloadIndex++ } } else { diff --git a/codecs/vp9_packet_test.go b/codecs/vp9_packet_test.go index d793798..2037670 100644 --- a/codecs/vp9_packet_test.go +++ b/codecs/vp9_packet_test.go @@ -227,7 +227,7 @@ func TestVP9Payloader_Payload(t *testing.T) { r0 := int(rand.New(rand.NewSource(0)).Int31n(0x7FFF)) //nolint:gosec var rands [][2]byte for i := 0; i < 10; i++ { - rands = append(rands, [2]byte{byte(r0>>8) | 0x80, byte(r0 & 0xFF)}) + rands = append(rands, [2]byte{byte(r0>>8) | 0x80, byte(r0 & 0xFF)}) //nolint:gosec // r0 is bounded to 0x7FFF r0++ } diff --git a/packetizer_test.go b/packetizer_test.go index 23d1076..eea51da 100644 --- a/packetizer_test.go +++ b/packetizer_test.go @@ -23,7 +23,7 @@ func TestPacketizer(t *testing.T) { if len(packets) != expectedLen { var packetlengths strings.Builder for i := range packets { - packetlengths.WriteString(fmt.Sprintf("Packet %d length %d\n", i, len(packets[i].Payload))) + fmt.Fprintf(&packetlengths, "Packet %d length %d\n", i, len(packets[i].Payload)) } assert.Failf( t, "Packetize failed", "Generated %d packets instead of %d\n%s", diff --git a/playoutdelayextension.go b/playoutdelayextension.go index bb728ff..21c3d40 100644 --- a/playoutdelayextension.go +++ b/playoutdelayextension.go @@ -43,8 +43,8 @@ func (p PlayoutDelayExtension) MarshalTo(buf []byte) (int, error) { return 0, io.ErrShortBuffer } buf[0] = byte(p.MinDelay >> 4) - buf[1] = byte(p.MinDelay<<4) | byte(p.MaxDelay>>8) - buf[2] = byte(p.MaxDelay) + buf[1] = byte(p.MinDelay<<4) | byte(p.MaxDelay>>8) //nolint:gosec // values validated above + buf[2] = byte(p.MaxDelay) //nolint:gosec // values validated above return playoutDelayExtensionSize, nil } @@ -57,8 +57,8 @@ func (p PlayoutDelayExtension) Marshal() ([]byte, error) { return []byte{ byte(p.MinDelay >> 4), - byte(p.MinDelay<<4) | byte(p.MaxDelay>>8), - byte(p.MaxDelay), + byte(p.MinDelay<<4) | byte(p.MaxDelay>>8), //nolint:gosec // values validated above + byte(p.MaxDelay), //nolint:gosec // values validated above }, nil } diff --git a/vlaextension.go b/vlaextension.go index 7b9646c..cc50005 100644 --- a/vlaextension.go +++ b/vlaextension.go @@ -158,7 +158,7 @@ func (v VLA) MarshalTo(buf []byte) (int, error) { //nolint:cyclop,gocognit offset := 0 // RID, NS, sl_bm fields - buf[offset] = byte(v.RTPStreamID<<6) | byte(v.RTPStreamCount-1)<<4 | ctx.commonSLBM + buf[offset] = byte(v.RTPStreamID<<6) | byte(v.RTPStreamCount-1)<<4 | ctx.commonSLBM //nolint:gosec // values are small if ctx.commonSLBM == 0 { offset++ @@ -182,7 +182,7 @@ func (v VLA) MarshalTo(buf []byte) (int, error) { //nolint:cyclop,gocognit temporalLayerIndex = 0 offset++ } - buf[offset] |= byte(len(v.ActiveSpatialLayer[idx].TargetBitrates)-1) << (2 * (3 - temporalLayerIndex)) + buf[offset] |= byte(len(v.ActiveSpatialLayer[idx].TargetBitrates)-1) << (2 * (3 - temporalLayerIndex)) //nolint:gosec // values are small temporalLayerIndex++ } } @@ -205,7 +205,7 @@ func (v VLA) MarshalTo(buf []byte) (int, error) { //nolint:cyclop,gocognit for _, sl := range v.ActiveSpatialLayer { binary.BigEndian.PutUint16(buf[offset+0:], uint16(sl.Width-1)) //nolint:gosec binary.BigEndian.PutUint16(buf[offset+2:], uint16(sl.Height-1)) //nolint:gosec - buf[offset+4] = byte(sl.Framerate) + buf[offset+4] = byte(sl.Framerate) //nolint:gosec // framerate fits in byte offset += 5 } }