Failure on test for decimal separator.

[gcng54]

Hello,

Thanks for efforts. I am new learner.
I forked your work for learn to java.

I did maven install/test and got below failures.

I thought these are interested in my operation system decimal separator. My system use "," instead of "."
I changed it but no change.

Best Regards

Code snippet (optional but helpful)

[ERROR] �[1;31mFailures: �[m
[ERROR] �[1;31m PhysicalQuantityTest.toEngineeringFormat_shouldReturnEngineeringString:167
expected: "20.12 [°C]"
but was: "20,12 [°C]"�[m
[ERROR] �[1;31m GeoCoordinateTest.toDMSFormat_shouldOutputInDegreeMinutesSecondsFormat:26
expected: "sea_quest = 52°14'2.796"S, 21°34'1.596"W"
but was: "sea_quest = 52°14'2,796"S, 21°34'1,596"W"�[m
[ERROR] �[1;31m GeoCoordinateTest.toDecimalDegrees_shouldOutputInDecimalDegreesFormat:49
expected: "sea_quest = -52.234, -21.567"
but was: "sea_quest = -52,234, -21,567"�[m
[ERROR] �[1;31m GeoCoordinateTest.toEngineeringFormat_shouldOutputInEngineeringFormat:68
expected: "sea_quest = -52.234 [°], -21.567 [°]"
but was: "sea_quest = -52,234 [°], -21,567 [°]"�[m
[ERROR] �[1;31m LatitudeTest.toDmsFormat_shouldOutputValidDMSFormat:76
expected: "lat = 52°14'5.1"N"
but was: "lat = 52°14'5,1"N"�[m
[ERROR] �[1;31m ValueFormatterTest.shouldFormatAndTruncateDoubleInputWithRespectOfRelevantDigits:40
expected: "0.000000124"
but was: "0,000000124"�[m
[ERROR] �[1;31m ValueFormatterTest.shouldFormatAndTruncateDoubleInputWithRespectOfRelevantDigits:40
expected: "0.123"
but was: "0,123"�[m
[ERROR] �[1;31m ValueFormatterTest.shouldFormatAndTruncateDoubleInputWithRespectOfRelevantDigits:40
expected: "0.0123"
but was: "0,0123"�[m
[ERROR] �[1;31m ValueFormatterTest.shouldFormatAndTruncateDoubleInputWithRespectOfRelevantDigits:40
expected: "0.000000123"
but was: "0,000000123"�[m
[ERROR] �[1;31m ValueFormatterTest.shouldFormatAndTruncateDoubleInputWithRespectOfRelevantDigits:40
expected: "0.001"
but was: "0,001"�[m
[ERROR] �[1;31m ValueFormatterTest.shouldFormatAndTruncateDoubleInputWithRespectOfRelevantDigits:40
expected: "-0.001"
but was: "-0,001"�[m
[ERROR] �[1;31m ValueFormatterTest.shouldFormatAndTruncateDoubleInputWithRespectOfRelevantDigits:40
expected: "10.123"
but was: "10,123"�[m
[ERROR] �[1;31m ValueFormatterTest.shouldFormatAndTruncateDoubleInputWithRespectOfRelevantDigits:40
expected: "10.124"
but was: "10,124"�[m
[ERROR] �[1;31m ValueFormatterTest.shouldFormatAndTruncateDoubleInput_whenRelevantDigitsAreLowerThan3:61
expected: "10.1"
but was: "10,1"�[m
[ERROR] �[1;31m ValueFormatterTest.shouldFormatAndTruncateDoubleInput_whenRelevantDigitsAreLowerThan3:61
expected: "10.12"
but was: "10,12"�[m
[ERROR] �[1;31m ValueFormatterTest.shouldFormatAndTruncateDoubleInput_whenRelevantDigitsAreLowerThan3:61
expected: "10.123"
but was: "10,123"�[m
[ERROR] �[1;31mErrors: �[m
[ERROR] �[1;31m CalculableQuantityTest.roundHalfEven_shouldFloorToNearestInteger:345 » NumberFormat For input string: "0,2"�[m
[INFO]
[ERROR] �[1;31mTests run: 379, Failures: 16, Errors: 1, Skipped: 0�[m

[pjazdzyk]

Hi @gcng54 thank you for reporting the issue!
I will investigate this in next few days and I will let you know of my findings.
Apologies for any inconvenience this caused.

[gcng54]

Hi,

I passed the tests with force constant separator without locale :))
Because even I change locale, there is no effect.

import java.text.DecimalFormatSymbols;

private static String formatValueToDecimalPlaces(double value, int numDecimalPlaces) {
String formatString = "#";
if (numDecimalPlaces > 0) {
formatString = "#." + "#".repeat(numDecimalPlaces);
}

    DecimalFormatSymbols symbols = new DecimalFormatSymbols();
    symbols.setDecimalSeparator('.');
    symbols.setGroupingSeparator(',');
    DecimalFormat decimalFormat = new DecimalFormat(formatString, symbols);

    decimalFormat.setRoundingMode(RoundingMode.HALF_EVEN);
    return decimalFormat.format(value);
}

[pjazdzyk]

Hi,

Thanks for the analysis, if this solves your issue, than you can create pull request if you want, I will include this in the next minor release, thanks!

[pjazdzyk]

Merged, thanks for contribution!

Will be included in 3.3.0 release.