All Distance Units have same functions (Distance, Length, Height, Width, Diameter, Thickness, Perimeter)

[gcng54]

Hi

Why all Distance Units are same class (Distance, Length, Height, Width, Diameter, Thickness, Perimeter)?

What if Distance_Base class and Interface?

Best regards

[pjazdzyk]

Hi,

The idea behind this is to provide named types for different quantities classes even if they have the same Unit implementation, which in this case is DistanceUnit. Normally Distance physical quantity could serve all purposes but, when you have a case, when you need different variants of distance - it is more convenient to to have different classes for this. For an example:

calculatePipeWeight(Diameter pipeDiameter, Length pipeLength, Thickness pipeWallThickness){
// some implementation
}

instead of:

calculatePipeWeight(Distance pipeDiameter, Distance pipeLength, Distance pipeWallThickness){
// some implementation
}

Thanks to having a dedicated type for specific quantity - all methods are more explicit, hard to make a mistake when putting variables in method arguments.
Also I prefer a style where "code duplication is better when excessive abstraction", therefore I don't plan to extracting common base of these all distance derived classes.

[gcng54]

Thanks for share your aspect.
I have wanted to add new distance types as yard, datamile, decameter and hectometer.
And add getter and setter for short abbreviation.

The "code duplication aspect" needs to many efforts.
I don't want your interrupt your aspect, your design is simple and efficient. Thanks for your sharing.

Best regards

[pjazdzyk]

No worries. If you give me the list of distance units you need, I will add this to the backlog and they will appear in next release in all distance-based quantities.

[pjazdzyk]

Done. I have added the distance units you have mentioned to all distance derived classess. To be included in release: 3.0.0.

You can checkout the branch: feature/3_0_0_relase_new_quantities, let me know if this is what you have expected, thanks!

[gcng54]

Thanks for your efforts.
You great.