From 1caae3eb2f6c16c45052e2f16a52c968dece2f80 Mon Sep 17 00:00:00 2001 From: Andrew Pikul Date: Tue, 25 Nov 2025 15:17:37 -0500 Subject: [PATCH 1/2] Relax read/write timing a bit --- tests/test_browser.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/test_browser.py b/tests/test_browser.py index 3e02bd09..84659846 100644 --- a/tests/test_browser.py +++ b/tests/test_browser.py @@ -137,7 +137,10 @@ async def test_browser_send_command_with_perf(browser): # Validate timing makes sense (write_start <= write_end <= read_end) write_start, write_end, read_end = perf - assert write_start <= write_end <= read_end + assert write_start <= write_end + assert write_start <= read_end + # read_end is tough because it happens on a different processor + # and it might actually be somewhat skewed perfs.append(perf) await asyncio.sleep(0.1) From c45e3019708fcefecded4d7bc417f6f72d13e613 Mon Sep 17 00:00:00 2001 From: Andrew Pikul Date: Tue, 25 Nov 2025 15:18:32 -0500 Subject: [PATCH 2/2] Add four seconds to timeout --- tests/conftest.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/conftest.py b/tests/conftest.py index 09145570..a4f9d258 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -1,10 +1,11 @@ import asyncio import logging -import choreographer as choreo import logistro import pytest import pytest_asyncio + +import choreographer as choreo from choreographer import errors _logger = logistro.getLogger(__name__) @@ -95,7 +96,7 @@ async def wrapped_test_fn(*args, **kwargs): def pytest_configure(): # change this by command line TODO - pytest.default_timeout = 20 # type: ignore[reportAttributeAccessIssue] + pytest.default_timeout = 24 # type: ignore[reportAttributeAccessIssue] # pytest shuts down its capture before logging/threads finish