refactor: decompose typegen/typescript module (#286)

Author: zharinov

crates/plotnik-lib/src/typegen/typescript.rs

@@ -0,0 +1,199 @@
+//! Type graph traversal and analysis.
+
+use std::collections::{HashMap, HashSet};
+
+use crate::bytecode::{QTypeId, TypeKind};
+
+use super::Emitter;
+
+impl Emitter<'_> {
+    pub(super) fn collect_builtin_references(&mut self) {
+        for i in 0..self.entrypoints.len() {
+            let ep = self.entrypoints.get(i);
+            self.collect_refs_recursive(ep.result_type);
+        }
+    }
+
+    fn collect_refs_recursive(&mut self, type_id: QTypeId) {
+        // Cycle detection
+        if !self.refs_visited.insert(type_id) {
+            return;
+        }
+
+        let Some(type_def) = self.types.get(type_id) else {
+            return;
+        };
+
+        let Some(kind) = type_def.type_kind() else {
+            return;
+        };
+
+        match kind {
+            TypeKind::Node => {
+                self.node_referenced = true;
+            }
+            TypeKind::String | TypeKind::Void => {
+                // No action needed for primitives
+            }
+            TypeKind::Struct | TypeKind::Enum => {
+                let member_types: Vec<_> = self
+                    .types
+                    .members_of(&type_def)
+                    .map(|m| m.type_id)
+                    .collect();
+                for ty in member_types {
+                    self.collect_refs_recursive(ty);
+                }
+            }
+            TypeKind::ArrayZeroOrMore | TypeKind::ArrayOneOrMore | TypeKind::Optional => {
+                self.collect_refs_recursive(QTypeId(type_def.data));
+            }
+            TypeKind::Alias => {
+                // Alias to Node
+                self.node_referenced = true;
+            }
+        }
+    }
+
+    pub(super) fn sort_topologically(&self, types: HashSet<QTypeId>) -> Vec<QTypeId> {
+        let mut deps: HashMap<QTypeId, HashSet<QTypeId>> = HashMap::new();
+        let mut rdeps: HashMap<QTypeId, HashSet<QTypeId>> = HashMap::new();
+
+        for &tid in &types {
+            deps.entry(tid).or_default();
+            rdeps.entry(tid).or_default();
+        }
+
+        // Build dependency graph
+        for &tid in &types {
+            for dep in self.get_direct_deps(tid) {
+                if types.contains(&dep) && dep != tid {
+                    deps.entry(tid).or_default().insert(dep);
+                    rdeps.entry(dep).or_default().insert(tid);
+                }
+            }
+        }
+
+        // Kahn's algorithm
+        let mut result = Vec::with_capacity(types.len());
+        let mut queue: Vec<QTypeId> = deps
+            .iter()
+            .filter(|(_, d)| d.is_empty())
+            .map(|(&tid, _)| tid)
+            .collect();
+
+        queue.sort_by_key(|tid| tid.0);
+
+        while let Some(tid) = queue.pop() {
+            result.push(tid);
+            if let Some(dependents) = rdeps.get(&tid) {
+                for &dependent in dependents {
+                    if let Some(dep_set) = deps.get_mut(&dependent) {
+                        dep_set.remove(&tid);
+                        if dep_set.is_empty() {
+                            queue.push(dependent);
+                            queue.sort_by_key(|t| t.0);
+                        }
+                    }
+                }
+            }
+        }
+
+        result
+    }
+
+    pub(super) fn collect_reachable_types(&self, type_id: QTypeId, out: &mut HashSet<QTypeId>) {
+        if out.contains(&type_id) {
+            return;
+        }
+
+        let Some(type_def) = self.types.get(type_id) else {
+            return;
+        };
+
+        let Some(kind) = type_def.type_kind() else {
+            return;
+        };
+
+        match kind {
+            TypeKind::Void | TypeKind::Node | TypeKind::String => {}
+            TypeKind::Struct => {
+                out.insert(type_id);
+                for member in self.types.members_of(&type_def) {
+                    self.collect_reachable_types(member.type_id, out);
+                }
+            }
+            TypeKind::Enum => {
+                out.insert(type_id);
+                for member in self.types.members_of(&type_def) {
+                    self.collect_enum_variant_refs(member.type_id, out);
+                }
+            }
+            TypeKind::Alias => {
+                out.insert(type_id);
+            }
+            TypeKind::ArrayZeroOrMore | TypeKind::ArrayOneOrMore | TypeKind::Optional => {
+                self.collect_reachable_types(QTypeId(type_def.data), out);
+            }
+        }
+    }
+
+    /// Collect reachable types from enum variant payloads.
+    /// Recurses into struct fields but doesn't add the payload struct itself.
+    fn collect_enum_variant_refs(&self, type_id: QTypeId, out: &mut HashSet<QTypeId>) {
+        let Some(type_def) = self.types.get(type_id) else {
+            return;
+        };
+
+        // For struct payloads, don't add the struct itself (it will be inlined),
+        // but recurse into its fields to find named types.
+        if type_def.type_kind() == Some(TypeKind::Struct) {
+            for member in self.types.members_of(&type_def) {
+                self.collect_reachable_types(member.type_id, out);
+            }
+        } else {
+            // For non-struct payloads, fall back to regular collection.
+            self.collect_reachable_types(type_id, out);
+        }
+    }
+
+    pub(super) fn get_direct_deps(&self, type_id: QTypeId) -> Vec<QTypeId> {
+        let Some(type_def) = self.types.get(type_id) else {
+            return vec![];
+        };
+
+        let Some(kind) = type_def.type_kind() else {
+            return vec![];
+        };
+
+        match kind {
+            TypeKind::Void | TypeKind::Node | TypeKind::String | TypeKind::Alias => vec![],
+            TypeKind::Struct | TypeKind::Enum => self
+                .types
+                .members_of(&type_def)
+                .flat_map(|member| self.unwrap_for_deps(member.type_id))
+                .collect(),
+            TypeKind::ArrayZeroOrMore | TypeKind::ArrayOneOrMore | TypeKind::Optional => {
+                self.unwrap_for_deps(QTypeId(type_def.data))
+            }
+        }
+    }
+
+    fn unwrap_for_deps(&self, type_id: QTypeId) -> Vec<QTypeId> {
+        let Some(type_def) = self.types.get(type_id) else {
+            return vec![];
+        };
+
+        let Some(kind) = type_def.type_kind() else {
+            return vec![];
+        };
+
+        match kind {
+            TypeKind::Void | TypeKind::Node | TypeKind::String => vec![],
+            TypeKind::ArrayZeroOrMore | TypeKind::ArrayOneOrMore | TypeKind::Optional => {
+                self.unwrap_for_deps(QTypeId(type_def.data))
+            }
+            TypeKind::Struct | TypeKind::Enum | TypeKind::Alias => vec![type_id],
+        }
+    }
+}

crates/plotnik-lib/src/typegen/typescript/analysis.rs

@@ -0,0 +1,40 @@
+//! Configuration types for TypeScript emission.
+
+use crate::Colors;
+
+/// How to represent the void type in TypeScript.
+#[derive(Clone, Copy, Debug, Default, PartialEq, Eq)]
+pub enum VoidType {
+    /// `undefined` - the absence of a value
+    #[default]
+    Undefined,
+    /// `null` - explicit null value
+    Null,
+}
+
+/// Configuration for TypeScript emission.
+#[derive(Clone, Debug)]
+pub struct Config {
+    /// Whether to export types
+    pub export: bool,
+    /// Whether to emit the Node type definition
+    pub emit_node_type: bool,
+    /// Use verbose node representation (with kind, text, etc.)
+    pub verbose_nodes: bool,
+    /// How to represent the void type
+    pub void_type: VoidType,
+    /// Color configuration for output
+    pub colors: Colors,
+}
+
+impl Default for Config {
+    fn default() -> Self {
+        Self {
+            export: true,
+            emit_node_type: true,
+            verbose_nodes: false,
+            void_type: VoidType::default(),
+            colors: Colors::OFF,
+        }
+    }
+}