.empty? throwing exception on nil value

[samjaninf]

In certain places in your files particularly in my case the host.pp and host/data.pp you have this:

'array' => inline_template("<%= (ips+[]).uniq.delete_if {|x| x.empty? }.join(',') %>"),

When I run that I get an error from puppet:

Error 400 on SERVER: Failed to parse inline template: undefined method `empty?‘ for :undef:Symbol

I believe it is because it is getting thrown a Nil value. I changed them to:

'array' => inline_template("<%= (ips+[]).uniq.delete_if {|x| x.nil? }.join(',') %>"),

and it seemed to work fine after that.

[purpleidea]

I don't recommend this change, because it empty values aren't seen by nil. Eg:

 => false 

I would accept a patch for an empty||nil test, however I think you should root cause why you're seeing nil's. I think that's the issue, likely in your setup somewhere...