Use an endpoint for the release edit button that's only rendered for staff users

Author: hugovk

downloads/views.py

@@ -267,3 +267,17 @@ def item_pubdate(self, item: Release) -> datetime | None:
                 return timezone.make_aware(item.release_date)
             return item.release_date
         return None
+
+
+class ReleaseEditButton(TemplateView):
+    """Render the release edit button (shown only to staff users).
+
+    This endpoint is not cached, allowing the edit button to appear
+    for staff users even when the release page itself is cached.
+    """
+    template_name = "downloads/release_edit_button.html"
+
+    def get_context_data(self, **kwargs):
+        context = super().get_context_data(**kwargs)
+        context["release_pk"] = self.kwargs["pk"]
+        return context

pydotorg/urls.py

@@ -8,6 +8,7 @@
 from django.conf import settings
 
 from cms.views import custom_404
+from downloads.views import ReleaseEditButton
 from users.views import HoneypotSignupView, CustomPasswordChangeView
 
 from . import views, urls_api
@@ -19,6 +20,7 @@
     path('', views.IndexView.as_view(), name='home'),
     re_path(r'^_health/?', views.health, name='health'),
     path('authenticated', views.AuthenticatedView.as_view(), name='authenticated'),
+    path('release-edit-button/<int:pk>', ReleaseEditButton.as_view(), name='release_edit_button'),
     re_path(r'^humans.txt$', TemplateView.as_view(template_name='humans.txt', content_type='text/plain')),
     re_path(r'^robots.txt$', TemplateView.as_view(template_name='robots.txt', content_type='text/plain')),
     re_path(r'^funding.json$', views.serve_funding_json, name='funding_json'),

templates/downloads/release_detail.html

@@ -22,9 +22,7 @@
 
 {% block content %}
     <article class="text">
-        {% if request.user.is_staff %}
-        <a role="button" class="button" href="{% url 'admin:downloads_release_change' release.pk %}">Edit this release</a>
-        {% endif %}
+        <span data-html-include="{% url 'release_edit_button' release.pk %}"></span>
 
         <header class="article-header">
             <h1 class="page-title">{{ release.name }}</h1>

templates/downloads/release_edit_button.html

@@ -0,0 +1,3 @@
+{% if request.user.is_staff %}
+<a role="button" class="button" href="{% url 'admin:downloads_release_change' release_pk %}">Edit this release</a>
+{% endif %}