Skip to content

Commit 60c25ed

Browse files
sammy-SCmeta-codesync[bot]
authored andcommitted
Remove dead StartupLogger::getRunJSBundleEndTime getter
Summary: `StartupLogger::getRunJSBundleEndTime()` was a public getter that returned the `runJSBundleEndTime` member, but it had no callers. `NativePerformance` is the only consumer of `StartupLogger` and reads the start-time getters plus `getAppStartupEndTime`, never this end-time getter. This removes the dead getter. The backing member `runJSBundleEndTime` is kept because `logStartupEvent`/`reset` still write it. Changelog: [Internal] Differential Revision: D108012912
1 parent 8d95ce4 commit 60c25ed

11 files changed

Lines changed: 0 additions & 14 deletions

packages/react-native/ReactCommon/cxxreact/ReactMarker.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -110,10 +110,6 @@ double StartupLogger::getRunJSBundleStartTime() {
110110
return runJSBundleStartTime;
111111
}
112112

113-
double StartupLogger::getRunJSBundleEndTime() {
114-
return runJSBundleEndTime;
115-
}
116-
117113
double StartupLogger::getAppStartupEndTime() {
118114
return appStartupEndTime;
119115
}

packages/react-native/ReactCommon/cxxreact/ReactMarker.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,6 @@ class RN_EXPORT StartupLogger {
9595
double getInitReactRuntimeStartTime();
9696
double getInitReactRuntimeEndTime();
9797
double getRunJSBundleStartTime();
98-
double getRunJSBundleEndTime();
9998
double getAppStartupEndTime();
10099

101100
private:

scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11713,7 +11713,6 @@ class facebook::react::ReactMarker::StartupLogger {
1171311713
public double getAppStartupStartTime();
1171411714
public double getInitReactRuntimeEndTime();
1171511715
public double getInitReactRuntimeStartTime();
11716-
public double getRunJSBundleEndTime();
1171711716
public double getRunJSBundleStartTime();
1171811717
public static facebook::react::ReactMarker::StartupLogger& getInstance();
1171911718
public void logStartupEvent(facebook::react::ReactMarker::ReactMarkerId markerId, double markerTime);

scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11366,7 +11366,6 @@ class facebook::react::ReactMarker::StartupLogger {
1136611366
public double getAppStartupStartTime();
1136711367
public double getInitReactRuntimeEndTime();
1136811368
public double getInitReactRuntimeStartTime();
11369-
public double getRunJSBundleEndTime();
1137011369
public double getRunJSBundleStartTime();
1137111370
public static facebook::react::ReactMarker::StartupLogger& getInstance();
1137211371
public void logStartupEvent(facebook::react::ReactMarker::ReactMarkerId markerId, double markerTime);

scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11566,7 +11566,6 @@ class facebook::react::ReactMarker::StartupLogger {
1156611566
public double getAppStartupStartTime();
1156711567
public double getInitReactRuntimeEndTime();
1156811568
public double getInitReactRuntimeStartTime();
11569-
public double getRunJSBundleEndTime();
1157011569
public double getRunJSBundleStartTime();
1157111570
public static facebook::react::ReactMarker::StartupLogger& getInstance();
1157211571
public void logStartupEvent(facebook::react::ReactMarker::ReactMarkerId markerId, double markerTime);

scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13544,7 +13544,6 @@ class facebook::react::ReactMarker::StartupLogger {
1354413544
public double getAppStartupStartTime();
1354513545
public double getInitReactRuntimeEndTime();
1354613546
public double getInitReactRuntimeStartTime();
13547-
public double getRunJSBundleEndTime();
1354813547
public double getRunJSBundleStartTime();
1354913548
public static facebook::react::ReactMarker::StartupLogger& getInstance();
1355013549
public void logStartupEvent(facebook::react::ReactMarker::ReactMarkerId markerId, double markerTime);

scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13259,7 +13259,6 @@ class facebook::react::ReactMarker::StartupLogger {
1325913259
public double getAppStartupStartTime();
1326013260
public double getInitReactRuntimeEndTime();
1326113261
public double getInitReactRuntimeStartTime();
13262-
public double getRunJSBundleEndTime();
1326313262
public double getRunJSBundleStartTime();
1326413263
public static facebook::react::ReactMarker::StartupLogger& getInstance();
1326513264
public void logStartupEvent(facebook::react::ReactMarker::ReactMarkerId markerId, double markerTime);

scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13407,7 +13407,6 @@ class facebook::react::ReactMarker::StartupLogger {
1340713407
public double getAppStartupStartTime();
1340813408
public double getInitReactRuntimeEndTime();
1340913409
public double getInitReactRuntimeStartTime();
13410-
public double getRunJSBundleEndTime();
1341113410
public double getRunJSBundleStartTime();
1341213411
public static facebook::react::ReactMarker::StartupLogger& getInstance();
1341313412
public void logStartupEvent(facebook::react::ReactMarker::ReactMarkerId markerId, double markerTime);

scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8698,7 +8698,6 @@ class facebook::react::ReactMarker::StartupLogger {
86988698
public double getAppStartupStartTime();
86998699
public double getInitReactRuntimeEndTime();
87008700
public double getInitReactRuntimeStartTime();
8701-
public double getRunJSBundleEndTime();
87028701
public double getRunJSBundleStartTime();
87038702
public static facebook::react::ReactMarker::StartupLogger& getInstance();
87048703
public void logStartupEvent(facebook::react::ReactMarker::ReactMarkerId markerId, double markerTime);

scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8553,7 +8553,6 @@ class facebook::react::ReactMarker::StartupLogger {
85538553
public double getAppStartupStartTime();
85548554
public double getInitReactRuntimeEndTime();
85558555
public double getInitReactRuntimeStartTime();
8556-
public double getRunJSBundleEndTime();
85578556
public double getRunJSBundleStartTime();
85588557
public static facebook::react::ReactMarker::StartupLogger& getInstance();
85598558
public void logStartupEvent(facebook::react::ReactMarker::ReactMarkerId markerId, double markerTime);

0 commit comments

Comments
 (0)