Fix unused parameter warnings in conversions.h (#56472)

christophpurrer · facebook-github-bot · commit cfbf7d716b4e · 2026-04-17T16:01:47.000-07:00
Summary:

Fix clang-diagnostic-unused-parameter warnings by commenting out the unused 'context' parameter in two fromRawValue functions. This maintains API compatibility while resolving the lint warnings.

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D101108449
diff --git a/packages/react-native/ReactCommon/react/renderer/components/image/conversions.h b/packages/react-native/ReactCommon/react/renderer/components/image/conversions.h
@@ -17,7 +17,7 @@
 
 namespace facebook::react {
 
-inline void fromRawValue(const PropsParserContext &context, const RawValue &value, ImageSource &result)
+inline void fromRawValue(const PropsParserContext & /* context */, const RawValue &value, ImageSource &result)
 {
   if (value.hasType<std::string>()) {
     result = {
@@ -116,7 +116,7 @@ inline std::string toString(const ImageSource &value)
   return "{uri: " + value.uri + "}";
 }
 
-inline void fromRawValue(const PropsParserContext &context, const RawValue &value, ImageResizeMode &result)
+inline void fromRawValue(const PropsParserContext & /* context */, const RawValue &value, ImageResizeMode &result)
 {
   react_native_expect(value.hasType<std::string>());
   if (!value.hasType<std::string>()) {

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@`
`17`	`17`
`18`	`18`	`namespace facebook::react {`
`19`	`19`
`20`		`-inline void fromRawValue(const PropsParserContext &context, const RawValue &value, ImageSource &result)`
	`20`	`+inline void fromRawValue(const PropsParserContext & /* context */, const RawValue &value, ImageSource &result)`
`21`	`21`	`{`
`22`	`22`	`if (value.hasType<std::string>()) {`
`23`	`23`	`result = {`
`@@ -116,7 +116,7 @@ inline std::string toString(const ImageSource &value)`
`116`	`116`	`return "{uri: " + value.uri + "}";`
`117`	`117`	`}`
`118`	`118`
`119`		`-inline void fromRawValue(const PropsParserContext &context, const RawValue &value, ImageResizeMode &result)`
	`119`	`+inline void fromRawValue(const PropsParserContext & /* context */, const RawValue &value, ImageResizeMode &result)`
`120`	`120`	`{`
`121`	`121`	`react_native_expect(value.hasType<std::string>());`
`122`	`122`	`if (!value.hasType<std::string>()) {`