Skip to content

Gate clipping to padding box logic#46194

Closed
joevilches wants to merge 4 commits into
react:mainfrom
joevilches:export-D61627637
Closed

Gate clipping to padding box logic#46194
joevilches wants to merge 4 commits into
react:mainfrom
joevilches:export-D61627637

Conversation

@joevilches

Copy link
Copy Markdown
Contributor

Summary:
tsia, we do not wanna ship out such a drastic change to core View logic without gating it first. Just gonna ship the box-shadow aspect of it before, while the proper clipping logic remains gated

Changelog: [Internal]

Differential Revision: D61627637

Joe Vilches and others added 3 commits August 23, 2024 14:58
Differential Revision: D61414649
Differential Revision: D61248625
Differential Revision: D61418470
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Aug 23, 2024
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D61627637

Summary:
Pull Request resolved: react#46194

tsia, we do not wanna ship out such a drastic change to core View logic without gating it first. Just gonna ship the box-shadow aspect of it before, while the proper clipping logic remains gated

Changelog: [Internal]

Differential Revision: D61627637
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D61627637

@react-native-bot

Copy link
Copy Markdown
Collaborator

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@react-native-bot react-native-bot added Stale There has been a lack of activity on this issue and it may be closed soon. and removed Stale There has been a lack of activity on this issue and it may be closed soon. labels Aug 23, 2025
@react-native-bot

Copy link
Copy Markdown
Collaborator

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@react-native-bot react-native-bot added Stale There has been a lack of activity on this issue and it may be closed soon. and removed Stale There has been a lack of activity on this issue and it may be closed soon. labels Feb 22, 2026
@react-native-bot

Copy link
Copy Markdown
Collaborator

Closing this PR as the diff D61627637 has been abandoned internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants