Skip to content
This repository was archived by the owner on Feb 17, 2020. It is now read-only.
This repository was archived by the owner on Feb 17, 2020. It is now read-only.

Memory leak on recursive unresolved promises. #39

@Istar-Eldritch

Description

@Istar-Eldritch

We use recursive promises in a couple places in the amqp backend. (setup and register functions). We should check if we have to trampoline them.

From the top of my head Iris only uses this recursion to keep the connection alive, thou only increasing the stack on connection loss. This means that the memory leaked in iris is negligible as the number of times the connection needs to drop for this to be noticeable it's likely to be never reached. (2-3Mb every 10k recursive calls)

Background and relevant links:
This problem was spotted while writing a new data transfer tool that was using recursive pagination to call the database using promises over Iris. The main issue was not in iris but the recursive call itself.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions