Fix MobileGestalt duplicate section and unsafe VFS fallback#262
Merged
Conversation
|
Can you add the function of cleaning system data? |
Contributor
Author
Could you clarify what you mean by “system data”? Do you mean things like cache, logs, OTA files, temporary files, etc.? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Internal.fallback_vfsoption tolara_overwritefile, defaulting totrueso existing callers keep the same behavior.Why
The duplicated
Internalsection contained the same SpringBoard/Pasteboard toggles already shown underSpringBoard.MobileGestalt writes are sensitive to file size changes. The sandbox overwrite path opens the file with
O_TRUNC, so it can safely replace the plist with a different-sized serialized plist. The VFS overwrite fallback cannot safely resize the target file: it rejects larger sources and zero-fills trailing bytes for smaller sources. If sandbox overwrite fails and MobileGestalt falls back to VFS, the plist can become corrupted.This keeps VFS fallback enabled by default for other overwrite users, but prevents it for MobileGestalt.
Testing
Internalsection.