feat(listReservations): lock in expires_*/finalized_* window passthrough (0.3.3)#104
Merged
Merged
Conversation
…ugh (0.3.3) Client-side companion to cycles-protocol-v0.yaml revision 2026-05-22 (runcycles/cycles-protocol#98) and runcycles/cycles-server#163. Closes the TypeScript-client side of issue #162. Follow-up to v0.3.2 with the same shape, just four more params. The existing `listReservations(params?: Record<string, string>)` signature already forwards arbitrary keys to the URL query string, so the four new ISO 8601 date-time params (expires_from / expires_to / finalized_from / finalized_to) work over the wire today without a code change. This commit adds a regression test that pins the URL-encoded passthrough. Call-site: await client.listReservations({ tenant: "acme", expires_from: "2026-05-22T00:00:00Z", expires_to: "2026-05-23T00:00:00Z", finalized_from: "2026-05-15T00:00:00Z", finalized_to: "2026-05-22T00:00:00Z", }); Colons URL-encoded to %3A per native fetch + URLSearchParams. No protocol or wire-format change; servers older than v0.1.25.21 silently ignore the new params per the additive-parameter guarantee. 317 tests pass at 98.4% statement / 99.62% line coverage. Bumped to 0.3.3, updated AUDIT.md and CHANGELOG.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Client-side companion to cycles-protocol-v0.yaml revision 2026-05-22 and cycles-server#163. Closes the TypeScript-client side of runcycles/cycles-server#162. Follow-up to v0.3.2 with the same shape, just four more params.
What this PR does
listReservationsconfirmingexpires_from/expires_to/finalized_from/finalized_toISO-8601 values are URL-encoded and forwarded to the query string. The existingparams?: Record<string, string>signature already accepts them — the test pins the contract.AUDIT.mdandCHANGELOG.md.No production code change.
Call-site
Verification
npm test: 317 passed, 5 skipped.npm run test:coverage: 98.4% statements / 99.62% lines (gate ≥95%).Test plan
Closes the TypeScript-client side of runcycles/cycles-server#162.