Release v1.3.1 #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

ryz310 merged 8 commits into release from master

Jun 10, 2025

.rubocop.yml

-Original file line number
+Diff line change
@@ -1,7 +1,5 @@
     plugins:
       - rubocop-performance
-    require:
       - rubocop-rake
       - rubocop-rspec
       - rubocop-rspec_rails
@@ Expand Down @@

CHANGELOG.md

-Original file line number
+Diff line change
@@ -1,5 +1,11 @@
     # Change log
+    ## v1.3.1 (Jun 10, 2025)
+    ### Misc
+    - [#1096](https://github.com/ryz310/my_api_client/pull/1096) Stubs `instance_reader` and `instance_writer` on the `class_attribute` ([@ryz310](https://github.com/ryz310))
     ## v1.3.0 (Jun 10, 2025)
     ### Feature
@@ Expand Down @@

Gemfile.lock

-Original file line number
+Diff line change
@@ -1,7 +1,7 @@
     PATH
       remote: .
       specs:
-        my_api_client (1.3.0)
+        my_api_client (1.3.1)
           activesupport (>= 6.1.0)
           faraday (>= 0.17.1)
           jsonpath
@@ Expand Down @@

lib/my_api_client/rspec/stub.rb

-Original file line number
+Diff line change
@@ Expand Up / @@ -68,7 +68,8 @@ def stub_api_client_all(klass, **actions_and_options) @@
         # @return [InstanceDouble]
         #   Returns a spy object of the stubbed ApiClient.
         def stub_api_client(klass, **actions_and_options)
-          instance = instance_double(klass)
+          instance = instance_double(klass, logger: klass.logger, 'logger=': nil,
+                                            error_handlers: klass.error_handlers)
           actions_and_options.each { |action, options| stubbing(instance, action, options) }
           instance
         end
@@ Expand Down @@

lib/my_api_client/version.rb

-Original file line number
+Diff line change
@@ -1,5 +1,5 @@
     # frozen_string_literal: true
     module MyApiClient
-      VERSION = '1.3.0'
+      VERSION = '1.3.1'
     end

spec/lib/my_api_client/rspec/stub_spec.rb

-Original file line number
+Diff line change
@@ Expand Up / @@ -59,6 +59,22 @@ def request_all @@
       end
       describe '#stub_api_client' do
+        describe 'class_attribute' do
+          let(:api_client) { stub_api_client(example_api_client) }
+          it 'stubs #logger' do
+            expect(api_client.logger).to eq example_api_client.logger
+          end
+          it 'stubs #logger=' do
+            expect { api_client.logger = Logger.new($stdout) }.not_to raise_error
+          end
+          it 'stubs #error_handlers' do
+            expect(api_client.error_handlers).to eq example_api_client.error_handlers
+          end
+        end
         context 'when use Proc' do
           let(:api_client) do
             stub_api_client(
@@ Expand Down @@

Provide feedback