Bzlmod Support

[javoire]

Hey! I didn't see this mentioned anywhere. Any plans for supporting projects using MODULE.bazel instead of WORKSPACE?

I've added an empty WORKSPACE file in my project in order to trigger this extension to activate, unfortunately I'm having various issues getting things to work which may or may not be related to this issue (but I'd be happy to discuss that in a separate issue)

Cheers

[guw]

No, there aren't any plans to build using Bazel. This is a vanilla VS Code extension. Thus NPM is needed to build it and VS Code also relies on non-Bazel tools to package and publish it.

bazel-vscode-java/.github/workflows/ci.yml

Line 91 in a73ed6f

run: npm run build

The Java based language server is a Maven build requiring specific extensions for OSGi/Eclipse extension development. That is not available for Bazel either.

The return on investment for using Bazel as a build system here is pretty low. What is your intended use case?

[javoire]

Ah sorry if I was unclear :) I'm referring to that the extension currently only looks for WORKSPACE files and not MODULE.bazel in order to trigger itself: https://github.com/salesforce/bazel-vscode-java?tab=readme-ov-file#getting-started

[guw]

Oh ah ... that makes a lot sense to have.

[BalestraPatrick]

@guw From a first look, we probably need to add support for considering a root Bazel workspace something that only has a MODULE.bazel. Some of the places I found where the existing codebase has this check are here:

• bazel-vscode-java/src/util.ts

  Line 50 in a73ed6f

  existsSync(join(workspaceRoot, 'WORKSPACE')) ||

• bazel-vscode-java/package.json

  Line 84 in a73ed6f

  "BUILD",

• bazel-vscode-java/syntaxes/starlark.tmLanguage.json

  Line 5 in a73ed6f

  "fileTypes": ["BUILD", "WORKSPACE", "bazel", "bzl", "sky", "star"],

• And we could probably create a new test project (similar to this) to make sure we test the case where bzlmod is only used and there's no WORKSPACE file anymore.

What are your thoughts?