Skip to content

Commit d9be3cb

Browse files
revert: drop merge-fix changes, keep only PR feedback
Keep only the messages change: 'Press Ctrl+C to stop the proxy server'. Revert ErrorPageRenderer, ProxyServer, and test changes - will address separately. Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent 2e80525 commit d9be3cb

6 files changed

Lines changed: 2 additions & 28 deletions

File tree

src/proxy/ProxyServer.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -412,8 +412,6 @@ export class ProxyServer extends EventEmitter {
412412
private initializeProxyHandler(): void {
413413
const manifest: WebAppManifest = this.config.manifest ?? {
414414
name: 'webapp',
415-
label: 'Web App',
416-
version: '1.0.0',
417415
outputDir: 'dist',
418416
};
419417

src/templates/ErrorPageRenderer.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
* limitations under the License.
1515
*/
1616

17+
import { getErrorPageTemplate } from '@salesforce/webapp-experimental/proxy';
1718
import type { DevServerError } from '../config/types.js';
18-
import { ERROR_PAGE_TEMPLATE } from './error-page-template.js';
1919

2020
export type ErrorPageData = {
2121
status: string;
@@ -35,7 +35,7 @@ export class ErrorPageRenderer {
3535
private template: string;
3636

3737
public constructor() {
38-
this.template = ERROR_PAGE_TEMPLATE;
38+
this.template = getErrorPageTemplate();
3939
}
4040

4141
/**

test/commands/webapp/dev.test.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@ describe('webapp:dev command integration', () => {
2929
it('should have correct WebAppManifest structure', () => {
3030
const manifest: WebAppManifest = {
3131
name: 'testWebApp',
32-
label: 'Test Web App',
33-
version: '1.0.0',
3432
outputDir: 'dist',
3533
dev: {
3634
url: 'http://localhost:5173',
@@ -64,8 +62,6 @@ describe('webapp:dev command integration', () => {
6462
it('should use manifest dev.url when no explicit URL', () => {
6563
const manifest: WebAppManifest = {
6664
name: 'testWebApp',
67-
label: 'Test Web App',
68-
version: '1.0.0',
6965
outputDir: 'dist',
7066
dev: {
7167
url: 'http://localhost:5173',
@@ -78,8 +74,6 @@ describe('webapp:dev command integration', () => {
7874
it('should use dev.command when no URL provided', () => {
7975
const manifest: WebAppManifest = {
8076
name: 'testWebApp',
81-
label: 'Test Web App',
82-
version: '1.0.0',
8377
outputDir: 'dist',
8478
dev: {
8579
command: 'npm run dev',
@@ -94,8 +88,6 @@ describe('webapp:dev command integration', () => {
9488
it('should validate manifest with dev.url', () => {
9589
const manifest: WebAppManifest = {
9690
name: 'testWebApp',
97-
label: 'Test Web App',
98-
version: '1.0.0',
9991
outputDir: 'dist',
10092
dev: {
10193
url: 'http://localhost:5173',
@@ -110,8 +102,6 @@ describe('webapp:dev command integration', () => {
110102
it('should validate manifest with dev.command', () => {
111103
const manifest: WebAppManifest = {
112104
name: 'testWebApp',
113-
label: 'Test Web App',
114-
version: '1.0.0',
115105
outputDir: 'dist',
116106
dev: {
117107
command: 'npm run dev',

test/config/ManifestWatcher.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@ describe('ManifestWatcher', () => {
2929

3030
const validManifest: WebAppManifest = {
3131
name: 'testApp',
32-
label: 'Test App',
33-
version: '1.0.0',
3432
outputDir: 'dist',
3533
dev: {
3634
command: 'npm run dev',

test/config/types.test.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@ describe('TypeScript Types', () => {
2121
it('should allow valid WebAppManifest', () => {
2222
const manifest: WebAppManifest = {
2323
name: 'testApp',
24-
label: 'Test App',
25-
version: '1.0.0',
2624
outputDir: 'dist',
2725
};
2826

@@ -33,8 +31,6 @@ describe('TypeScript Types', () => {
3331
it('should allow WebAppManifest with dev config', () => {
3432
const manifest: WebAppManifest = {
3533
name: 'testApp',
36-
label: 'Test App',
37-
version: '1.0.0',
3834
outputDir: 'dist',
3935
dev: {
4036
command: 'npm run dev',
@@ -56,8 +52,6 @@ describe('TypeScript Types', () => {
5652

5753
const manifest: WebAppManifest = {
5854
name: 'testApp',
59-
label: 'Test App',
60-
version: '1.0.0',
6155
outputDir: 'dist',
6256
routing,
6357
};

test/proxy/ProxyServer.test.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,6 @@ describe('ProxyServer', () => {
122122
salesforceInstanceUrl: 'https://test.salesforce.com',
123123
manifest: {
124124
name: 'test-app',
125-
label: 'Test App',
126-
version: '1.0.0',
127125
outputDir: 'dist',
128126
},
129127
});
@@ -227,17 +225,13 @@ describe('ProxyServer', () => {
227225
salesforceInstanceUrl: 'https://test.salesforce.com',
228226
manifest: {
229227
name: 'test-app',
230-
label: 'Test App',
231-
version: '1.0.0',
232228
outputDir: 'dist',
233229
},
234230
});
235231

236232
// Update manifest with routing config
237233
proxy.updateManifest({
238234
name: 'test-app',
239-
label: 'Test App',
240-
version: '1.0.0',
241235
outputDir: 'dist',
242236
routing: {
243237
trailingSlash: 'always',

0 commit comments

Comments
 (0)