Skip to content

dotfile pull improvement on file saving #91

@AnnatarHe

Description

@AnnatarHe

Please improve the file-saving aspect of the dotfiles pull command.

The entry for the dotfiles pull command is located in commands/dotfiles_pull.go#L14, while the file-saving functionality can be found in main/model/dotfile_apps.go#L211.

In the file-saving section, you don't need to call the IsEqual check first, as it will be guarded before the save method is invoked.

Additionally, in the file-saving part, you should check the differences first using https://github.com/sergi/go-diff and only apply the changes to the current file.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions