Skip to content

fix(install): warn when shelltime-daemon is missing from archive #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AnnatarHe merged 1 commit into from
May 20, 2026
Merged

fix(install): warn when shelltime-daemon is missing from archive #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions install.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,12 @@ if [[ "$OS" == "Darwin" ]] || [[ "$OS" == "Linux" ]]; then
mv shelltime "$HOME/.shelltime/bin/"
if [ -f "shelltime-daemon" ]; then
mv shelltime-daemon "$HOME/.shelltime/bin/"
else
echo "" >&2
echo "WARNING: shelltime-daemon binary was NOT found in $FILENAME." >&2
echo " The CLI will attempt to auto-download it on first" >&2
echo " 'shelltime daemon install/reinstall'." >&2
echo "" >&2
Comment on lines +148 to +152
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The warning message is a helpful addition. However, the current wording is somewhat passive. Since the automatic attempt to reinstall the daemon at the end of this script (line 296) will likely fail on fresh installations (because the shelltime binary is not yet in the current shell's PATH and the output is suppressed), providing an explicit, actionable command for the user is more robust. This ensures they know exactly how to resolve the missing daemon issue if the automatic step fails silently.

Suggested change
echo "" >&2
echo "WARNING: shelltime-daemon binary was NOT found in $FILENAME." >&2
echo " The CLI will attempt to auto-download it on first" >&2
echo " 'shelltime daemon install/reinstall'." >&2
echo "" >&2
echo "" >&2
echo "WARNING: shelltime-daemon binary was NOT found in $FILENAME." >&2
echo " The CLI will attempt to auto-download it. Please run:" >&2
echo " $HOME/.shelltime/bin/shelltime daemon install" >&2
echo "" >&2

fi
# elif [[ "$OS" == "MINGW64_NT" ]] || [[ "$OS" == "MSYS_NT" ]] || [[ "$OS" == "CYGWIN_NT" ]]; then
# mv shelltime /c/Windows/System32/
Expand Down
Loading