Skip to content

Commit 51b95b5

Browse files
committed
Pass dialect string (not Dialect instance) to symmetric aggregate builder
build_symmetric_aggregate_sql branches on dialect name strings like "bigquery", "postgres", etc. Passing self._dialect_instance (a Dialect object) would miss all branches and fall back to DuckDB SQL, producing invalid SQL for non-DuckDB engines.
1 parent 3f2af1f commit 51b95b5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

sidemantic/sql/generator.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1898,7 +1898,7 @@ def _build_main_select(
18981898
primary_key=pk,
18991899
agg_type=measure.agg,
19001900
model_alias=f"{model_name}_cte",
1901-
dialect=self._dialect_instance,
1901+
dialect=self.dialect,
19021902
)
19031903
else:
19041904
# Use helper that applies metric-level filters via CASE WHEN

0 commit comments

Comments
 (0)