From 303e90a1c4c9f264bb170eb8f8950b93e6787601 Mon Sep 17 00:00:00 2001 From: Adwait Kumar Singh Date: Tue, 31 Mar 2026 15:28:15 -0700 Subject: [PATCH] Remove useExternalTypes since its not used anywhere --- .../smithy/java/codegen/JavaCodegenSettings.java | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/codegen/codegen-core/src/main/java/software/amazon/smithy/java/codegen/JavaCodegenSettings.java b/codegen/codegen-core/src/main/java/software/amazon/smithy/java/codegen/JavaCodegenSettings.java index 295b03be7..8984048fc 100644 --- a/codegen/codegen-core/src/main/java/software/amazon/smithy/java/codegen/JavaCodegenSettings.java +++ b/codegen/codegen-core/src/main/java/software/amazon/smithy/java/codegen/JavaCodegenSettings.java @@ -47,7 +47,6 @@ public final class JavaCodegenSettings { private static final String RELATIVE_DATE = "relativeDate"; private static final String RELATIVE_VERSION = "relativeVersion"; private static final String EDITION = "edition"; - private static final String USE_EXTERNAL_TYPES = "useExternalTypes"; private static final String RUNTIME_TRAITS = "runtimeTraits"; private static final String RUNTIME_TRAITS_SELECTOR = "runtimeTraitsSelector"; private static final String MODES = "modes"; @@ -65,7 +64,6 @@ public final class JavaCodegenSettings { RELATIVE_DATE, RELATIVE_VERSION, EDITION, - USE_EXTERNAL_TYPES, RUNTIME_TRAITS, RUNTIME_TRAITS_SELECTOR, MODES); @@ -83,7 +81,6 @@ public final class JavaCodegenSettings { private final String relativeDate; private final String relativeVersion; private final SmithyJavaCodegenEdition edition; - private final boolean useExternalTypes; private final List runtimeTraits; private final Selector runtimeTraitsSelector; private final ObjectNode httpConfig; @@ -103,7 +100,6 @@ private JavaCodegenSettings(Builder builder) { this.relativeDate = builder.relativeDate; this.relativeVersion = builder.relativeVersion; this.edition = Objects.requireNonNullElse(builder.edition, SmithyJavaCodegenEdition.LATEST); - this.useExternalTypes = builder.useExternalTypes; this.runtimeTraits = Collections.unmodifiableList(builder.runtimeTraits); this.runtimeTraitsSelector = builder.runtimeTraitsSelector; this.httpConfig = builder.httpConfig; @@ -130,7 +126,6 @@ public static JavaCodegenSettings fromNode(ObjectNode settingsNode) { .getStringMember(RELATIVE_DATE, builder::relativeDate) .getStringMember(RELATIVE_VERSION, builder::relativeVersion) .getStringMember(EDITION, builder::edition) - .getBooleanMember(USE_EXTERNAL_TYPES, builder::useExternalTypes) .getArrayMember(RUNTIME_TRAITS, n -> n.expectStringNode().expectShapeId(), builder::runtimeTraits) .getStringMember(RUNTIME_TRAITS_SELECTOR, builder::runtimeTraitsSelector) .getObjectMember(HTTP_CONFIG, builder::httpConfig); @@ -196,10 +191,6 @@ public SmithyJavaCodegenEdition edition() { return edition; } - public boolean useExternalTypes() { - return useExternalTypes; - } - public List runtimeTraits() { return runtimeTraits; } @@ -256,7 +247,6 @@ public static final class Builder { private SmithyJavaCodegenEdition edition; private final List runtimeTraits = new ArrayList<>(); private Selector runtimeTraitsSelector; - private boolean useExternalTypes; private ObjectNode httpConfig; public Builder service(String string) { @@ -347,11 +337,6 @@ public Builder edition(String string) { return this; } - public Builder useExternalTypes(boolean useExternalTypes) { - this.useExternalTypes = useExternalTypes; - return this; - } - public Builder runtimeTraits(List runtimeTraits) { this.runtimeTraits.addAll(runtimeTraits); return this;