diff --git a/.changeset/violet-cooks-dream.md b/.changeset/violet-cooks-dream.md new file mode 100644 index 0000000000..8acda58b86 --- /dev/null +++ b/.changeset/violet-cooks-dream.md @@ -0,0 +1,5 @@ +--- +'@solid-design-system/components': patch +--- + +Fixed the focus ring on the `sd-teaser-media` expandable toggle so it is clearly visible across all variants diff --git a/packages/components/src/components/datepicker/datepicker.test.ts b/packages/components/src/components/datepicker/datepicker.test.ts index 4d43f68ec2..81dcd15b1f 100644 --- a/packages/components/src/components/datepicker/datepicker.test.ts +++ b/packages/components/src/components/datepicker/datepicker.test.ts @@ -1,5 +1,4 @@ import '../../../dist/solid-components'; -import { clickOnElement } from '../../internal/test.js'; import { expect, fixture, html, waitUntil } from '@open-wc/testing'; import { sendKeys } from '@web/test-runner-commands'; import sinon from 'sinon'; @@ -176,9 +175,9 @@ describe('', () => { await el.updateComplete; const dayButtons = el.shadowRoot!.querySelectorAll('button.day:not(.out-month):not(.disabled)'); - await clickOnElement(dayButtons[5]); + (dayButtons[5] as HTMLButtonElement).click(); await el.updateComplete; - await clickOnElement(dayButtons[10]); + (dayButtons[10] as HTMLButtonElement).click(); await el.updateComplete; expect(el.rangeStart).to.not.be.null; @@ -195,7 +194,7 @@ describe('', () => { await el.updateComplete; const dayButtons = el.shadowRoot!.querySelectorAll('button.day:not(.out-month):not(.disabled)'); - await clickOnElement(dayButtons[5]); + (dayButtons[5] as HTMLButtonElement).click(); await el.updateComplete; expect(rangeSelectHandler).to.have.been.calledOnce; @@ -208,9 +207,9 @@ describe('', () => { await el.updateComplete; const dayButtons = el.shadowRoot!.querySelectorAll('button.day:not(.out-month):not(.disabled)'); - await clickOnElement(dayButtons[10]); + (dayButtons[10] as HTMLButtonElement).click(); await el.updateComplete; - await clickOnElement(dayButtons[5]); + (dayButtons[5] as HTMLButtonElement).click(); await el.updateComplete; expect(el.rangeStart).to.not.be.null; diff --git a/packages/components/src/components/teaser-media/teaser-media.ts b/packages/components/src/components/teaser-media/teaser-media.ts index 46aebbed79..a56cff8fd0 100644 --- a/packages/components/src/components/teaser-media/teaser-media.ts +++ b/packages/components/src/components/teaser-media/teaser-media.ts @@ -203,6 +203,12 @@ export default class SdTeaserMedia extends SolidElement { [part='toggle'] { @apply w-fit; + @apply outline-transparent; + } + + :host([variant='primary']) [part='toggle']:focus-visible, + :host([variant='gradient-dark']) [part='toggle']:focus-visible { + outline-color: rgba(var(--sd-color-text-white)); } ` ];