-
Notifications
You must be signed in to change notification settings - Fork 227
Open
Description
I'm running into an error specifically with this line of code:
virtus/lib/virtus/attribute_set.rb
Line 196 in 4db9ffd
| ::Hash.try_convert(attributes) or raise( |
In Rails 4 and below calling to_hash on parameters was easy and returned the expected hash as follows:
> ::Hash.try_convert(ActionController::Parameters.new({foo: "bar"}))
=> {"foo"=>"bar"}However this behavior changed in Rails 5 and started to raise an error:
> ::Hash.try_convert(ActionController::Parameters.new({foo: "bar"}))
=> ActionController::UnfilteredParameters (unable to convert unpermitted parameters to hash)Therefore I think Virtus needs to be slightly more intelligent about how it coerces to a hash.
I have gone ahead and implemented a PR that should fix the issue I am seeing as well as a test to replicate the issue and verify it's fix in #388
Metadata
Metadata
Assignees
Labels
No labels