subtitled_pending false positive on recordings without subtitle burn

[liususan091219]

subtitled_pending=true for ALL recordings even without subtitle burn. Fix: PR #355. POC: scripts/poc-pr355-subtitled-pending.sh (9/9). Linked: #355

[liususan091219]

Manual test

1. Check out main (before PR fix: subtitled_pending false positive in open_file #355): current main has the old one-liner
2. Record screen for 10s (WITHOUT narration/subtitles), then say "open it"
3. Expected (bug): Model says "subtitles are still generating" even though no subtitle burn was requested
4. Apply PR fix: subtitled_pending false positive in open_file #355 branch: git checkout fix/subtitled-pending-false-positive
5. Restart voice agent, repeat the recording
6. Expected (fix): Model says "File opened" without mentioning subtitles

POC verification

bash scripts/poc-pr355-subtitled-pending.sh  # 9/9 pass

Phase 0 creates a mock recording with no SRT — old logic returns subtitled_pending=true (false positive). Phase 1 shows new logic returns false.

[liususan091219]

Reproducing the bug

Buggy version: current main (commit 2be13be) — PR #355 not yet merged
Fixed version: git checkout origin/fix/subtitled-pending-false-positive (commit ac70118)

On main, subtitled_pending is true for all recordings. On the fix branch, it checks SRT existence first.

[liususan091219]

Related: #356 (also in recording-tools.ts — open_file 18s polling timeout, PR #353)

[sonichi]

Already fixed — see linked PR.