Merge pull request #231 from splitio/development

Development

Author: ZamoraEmmanuel

.github/workflows/update-license-year.yml

@@ -38,7 +38,7 @@ jobs:
           git commit -m "Updated License Year" -a
 
       - name: Create Pull Request
-        uses: peter-evans/create-pull-request@v7
+        uses: peter-evans/create-pull-request@v8
         with:
           token: ${{ secrets.GITHUB_TOKEN }}
           title: Update License Year

.jest/setEnvVars.js

@@ -14,8 +14,9 @@ jest.mock('../sdk', () => ({
   getSplitFactory: jest.fn((settings) => {
     const { __dirname } = require('../utils/utils');
     const path = require('path');
-    const { apiKeyMocksMap } = require('../utils/mocks')
-
+    const { apiKeyMocksMap } = require('../utils/mocks');
+    const { syncManagerOfflineFactory } = require('@splitsoftware/splitio-commons/cjs/sync/offline/syncManagerOffline');
+    const { splitsParserFromFileFactory } = require('../sdk/sync/splitsParserFromFile');
     // Clients are configured in localhost mode if there is a features file maped to the authorizationKey value in mocksMap
 
     let features = '';
@@ -61,7 +62,16 @@ jest.mock('../sdk', () => ({
     };
 
     let sdk = jest.requireActual('../sdk');
-    const { factory, impressionsMode } = sdk.getSplitFactory(configForMock);
+    
+    const moduleOverrider = (modules) => {
+      if (features) {
+        modules.splitApiFactory = undefined;
+        modules.syncManagerFactory = syncManagerOfflineFactory(splitsParserFromFileFactory)
+        modules.SignalListener = undefined;
+      }
+    };
+
+    const { factory, impressionsMode } = sdk.getSplitFactory(configForMock, moduleOverrider);
 
     const mockedTelemetry = {
       splits: {

.nvmrc

@@ -1 +1 @@
-v20.13.1
+v24.12

CHANGES.txt

@@ -1,3 +1,8 @@
+2.9.0 (Dec 16, 2025)
+  - Updated base image to node:24.12.0-alpine3.22
+  - Updated @splitsoftware/splitio library, using @splitsoftware/splitio-commons:2.10.0 instead that includes
+    - Added property `impressionsDisabled` in getTreatment(s) `evaluationOptions` parameter, to disable impressions per evaluations.
+
 2.8.1 (Oct 13, 2025)
   - Updated base image to node:24.10.0-alpine3.22
 

Dockerfile

@@ -1,5 +1,5 @@
 # Builder stage
-FROM node:24.10.0-alpine3.22 AS builder
+FROM node:24.12.0-alpine3.22 AS builder
 
 WORKDIR /usr/src/split-evaluator
 
@@ -8,7 +8,7 @@ COPY package.json package-lock.json ./
 RUN npm install --only=production
 
 # Runner stage
-FROM node:24.10.0-alpine3.22 AS runner
+FROM node:24.12.0-alpine3.22 AS runner
 
 WORKDIR /usr/src/split-evaluator
 

admin/__tests__/machine.test.js

@@ -1,5 +1,5 @@
 const os = require('os');
-const ip = require('@splitsoftware/splitio/cjs/utils/ip');
+const ip = require('../../sdk/utils/ip');
 const request = require('supertest');
 const app = require('../../app');
 const { expectError } = require('../../utils/testWrapper/index');

admin/admin.controller.js

@@ -1,5 +1,5 @@
 const os = require('os');
-const ip = require('@splitsoftware/splitio/cjs/utils/ip');
+const ip = require('../sdk/utils/ip');
 
 const utils = require('../utils/utils');
 const environmentManager = require('../environmentManager').getInstance();

client/__tests__/allTreatments.test.js

@@ -227,6 +227,9 @@ describe('get-all-treatments', () => {
         'other-experiment-2': {
           treatment: 'on',
         },
+        'other-experiment-4': {
+          treatment: 'on',
+        },
       },
     };
     const response = await request(app)
@@ -242,6 +245,9 @@ describe('get-all-treatments', () => {
         'my-experiment': {
           treatment: 'on',
         },
+        'other-experiment-4': {
+          treatment: 'on',
+        },
         'other-experiment-3': {
           treatment: 'off',
         },
@@ -277,6 +283,42 @@ describe('get-all-treatments', () => {
     expect(response.status).toBe(200);
   });
 
+  test('should be 200 if impressionsDisabled parameter is valid (GET)', async () => {
+    const response = await request(app)
+      .get('/client/get-all-treatments?keys=[{"matchingKey":"test","trafficType":"localhost"}]&properties={"foo": {"bar": 1}}&impressions-disabled=true')
+      .set('Authorization', 'test');
+    expect(response.status).toBe(200);
+  });
+
+  test('should be 200 if impressionsDisabled parameter is valid (POST)', async () => {
+    const response = await request(app)
+      .post('/client/get-all-treatments?keys=[{"matchingKey":"test","trafficType":"localhost"}]')
+      .send({
+        properties: { package: 'premium', admin: true, discount: 50 },
+        impressionsDisabled: true,
+      })
+      .set('Authorization', 'test');
+    expect(response.status).toBe(200);
+  });
+
+  test('should be 200 if impressionsDisabled parameter is invalid (GET)', async () => {
+    const response = await request(app)
+      .get('/client/get-all-treatments?keys=[{"matchingKey":"test","trafficType":"localhost"}]&properties={"foo": {"bar": 1}}&impressions-disabled={"a":1}')
+      .set('Authorization', 'test');
+    expect(response.status).toBe(200);
+  });
+
+  test('should be 200 if impressionsDisabled parameter is invalid (POST)', async () => {
+    const response = await request(app)
+      .post('/client/get-all-treatments?keys=[{"matchingKey":"test","trafficType":"localhost"}]')
+      .send({
+        properties: { package: 'premium', admin: true, discount: 50 },
+        impressionsDisabled: { a: 1 },
+      })
+      .set('Authorization', 'test');
+    expect(response.status).toBe(200);
+  });
+
   test('should be 200 if properties is invalid (GET)', async () => {
     const response = await request(app)
       .get('/client/get-all-treatments?keys=[{"matchingKey":"test","trafficType":"localhost"}]&properties={"foo": {"bar": 1}}')

client/__tests__/allTreatmentsWithConfig.test.js

@@ -231,6 +231,10 @@ describe('get-all-treatments-with-config', () => {
           treatment: 'on',
           config: null,
         },
+        'other-experiment-4': {
+          treatment: 'on',
+          config: null,
+        },
       },
     };
     const response = await request(app)
@@ -259,6 +263,10 @@ describe('get-all-treatments-with-config', () => {
           treatment: 'on',
           config: null,
         },
+        'other-experiment-4': {
+          treatment: 'on',
+          config: null,
+        },
       },
       account: {},
     };
@@ -285,6 +293,43 @@ describe('get-all-treatments-with-config', () => {
     expect(response.status).toBe(200);
   });
 
+  test('should be 200 if impressionsDisabled parameter is valid (GET)', async () => {
+    const response = await request(app)
+      .get('/client/get-all-treatments-with-config?keys=[{"matchingKey":"test","trafficType":"localhost"}]&properties={"foo": {"bar": 1}}&impressions-disabled=true')
+      .set('Authorization', 'test');
+    expect(response.status).toBe(200);
+  });
+
+  test('should be 200 if impressionsDisabled parameter is valid (POST)', async () => {
+    const response = await request(app)
+      .post('/client/get-all-treatments-with-config?keys=[{"matchingKey":"test","trafficType":"localhost"}]')
+      .send({
+        properties: { foo: { bar: 1 } },
+        impressionsDisabled: true,
+      })
+      .set('Authorization', 'test');
+    expect(response.status).toBe(200);
+  });
+
+  test('should be 200 if impressionsDisabled parameter is invalid (GET)', async () => {
+    const response = await request(app)
+      .get('/client/get-all-treatments-with-config?keys=[{"matchingKey":"test","trafficType":"localhost"}]&properties={"foo": {"bar": 1}}&impressions-disabled={"a":1}')
+      .set('Authorization', 'test');
+    expect(response.status).toBe(200);
+  });
+
+  test('should be 200 if impressionsDisabled parameter is invalid (POST)', async () => {
+    const response = await request(app)
+      .post('/client/get-all-treatments-with-config?keys=[{"matchingKey":"test","trafficType":"localhost"}]')
+      .send({
+        properties: { foo: { bar: 1 } },
+        impressionsDisabled: { a: 1 },
+      })
+      .set('Authorization', 'test');
+    expect(response.status).toBe(200);
+  });
+
+
   test('should be 200 if properties is invalid (GET)', async () => {
     const response = await request(app)
       .get('/client/get-all-treatments-with-config?keys=[{"matchingKey":"test","trafficType":"localhost"}]&properties={"foo": {"bar": 1}}')

client/__tests__/treatment.test.js

@@ -281,4 +281,40 @@ describe('get-treatment', () => {
       .set('Authorization', 'test');
     expectOk(response, 200, 'on', 'my-experiment');
   });
+
+  test('should be 200 if impressionsDisabled is valid (GET)', async () => {
+    const response = await request(app)
+      .get('/client/get-treatment?key=test&split-name=my-experiment&properties={"package":"premium","admin":true,"discount":50}&impressions-disabled=true')
+      .set('Authorization', 'test');
+    expectOk(response, 200, 'on', 'my-experiment');
+  });
+
+  test('should be 200 if impressionsDisabled is valid (POST)', async () => {
+    const response = await request(app)
+      .post('/client/get-treatment?key=test&split-name=my-experiment&impressions-disabled=true')
+      .send({
+        properties: { package: 'premium', admin: true, discount: 50 },
+        impressionsDisabled: true,
+      })
+      .set('Authorization', 'test');
+    expectOk(response, 200, 'on', 'my-experiment');
+  });
+
+  test('should be 200 if impressionsDisabled is invalid (GET)', async () => {
+    const response = await request(app)
+      .get('/client/get-treatment?key=test&split-name=my-experiment&properties={"foo": {"bar": 1}}&impressions-disabled=lalala')
+      .set('Authorization', 'test');
+    expectOk(response, 200, 'on', 'my-experiment');
+  });
+
+  test('should be 200 if impressionsDisabled is invalid (POST)', async () => {
+    const response = await request(app)
+      .post('/client/get-treatment?key=test&split-name=my-experiment')
+      .send({
+        properties: { foo: { bar: 1 } },
+        impressionsDisabled: 'lalala',
+      })
+      .set('Authorization', 'test');
+    expectOk(response, 200, 'on', 'my-experiment');
+  });
 });