From bf62fbe52f9f0c1391c0e1ddf84ac7b900f5514d Mon Sep 17 00:00:00 2001 From: Chris Stockton Date: Thu, 14 May 2026 05:50:44 -0700 Subject: [PATCH] fix: when version is empty set to 0.0.0 When no version is set the version metrics will exit, it's better to set the version to 0.0.0 for local dev and to serve as a signal no version was set. --- internal/utilities/version/version.go | 3 +++ internal/utilities/version/version_test.go | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/internal/utilities/version/version.go b/internal/utilities/version/version.go index 91ceafda73..e26cfd8f85 100644 --- a/internal/utilities/version/version.go +++ b/internal/utilities/version/version.go @@ -80,6 +80,9 @@ func parseSemver(ver string) (*versionInfo, error) { vi := &versionInfo{ Original: ver, } + if ver == "" { + ver = "0.0.0-unknown" + } ver = normalizeVersion(ver) sv, err := semver.NewVersion(ver) diff --git a/internal/utilities/version/version_test.go b/internal/utilities/version/version_test.go index 55f73b8930..91e90be3e5 100644 --- a/internal/utilities/version/version_test.go +++ b/internal/utilities/version/version_test.go @@ -144,8 +144,8 @@ func TestVersionParseSemver(t *testing.T) { {str: "2.165.1-rc.1.5", maj: 2, min: 165, pat: 1, rc: 1}, {str: "2.165.1-rc1.5", maj: 2, min: 165, pat: 1, rc: 1}, + {str: "", maj: 0, min: 0, pat: 0, rc: 0}, - {str: "", err: "Invalid Semantic Version"}, {str: "abc", err: "Invalid Semantic Version"}, }