fix: consolidate deletions under new replacement#2094
Open
fix: consolidate deletions under new replacement#2094
Conversation
Collaborator
palmer-cl
commented
Feb 18, 2026
palmer-cl
commented
- allow for overriding of tracked deletes with a new replacement or deletion
- normal tracked change removals stay the same (no id replace)
- add visual and unit tests
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Contributor
Visual diffs detectedPixel differences were found in visual tests. This is not blocking — reproduce locally with |
caio-pizzol
approved these changes
Feb 18, 2026
Contributor
There was a problem hiding this comment.
nice refactor on the deletion marking logic -- the three-case branching (own insertions / existing deletions / non-deleted nodes) is much clearer than before.
left a few minor comments, but feel free to merge it after addressing them (if relevant)
packages/super-editor/src/extensions/track-changes/trackChangesHelpers/replaceStep.js
Outdated
Show resolved
Hide resolved
packages/super-editor/src/extensions/track-changes/trackChangesHelpers/trackedTransaction.js
Show resolved
Hide resolved
packages/super-editor/src/extensions/track-changes/trackChangesHelpers/markDeletion.js
Outdated
Show resolved
Hide resolved
...es/super-editor/src/extensions/track-changes/trackChangesHelpers/trackChangesHelpers.test.js
Outdated
Show resolved
Hide resolved
tests/visual/tests/behavior/comments-tcs/replace-over-multi-paragraph-tracked-changes.spec.ts
Outdated
Show resolved
Hide resolved
…applying-tracked-changes-over
…applying-tracked-changes-over
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.