merge: from main to 3.0#34603
Conversation
fix(stream): fix ci case issues
guanshengliang
requested review from
a team,
dapan1121,
hzcheng and
zitsen
as code owners
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request merges changes from the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is a merge from the main branch and includes a variety of changes. My review has identified a potential null pointer dereference in mndXnode.c which could lead to a crash, and a documentation inconsistency in the Chinese version of taosc.md. Other changes, including bug fixes and test additions, appear to be correct.
| pJson = tjsonCreateObject(); | ||
| goto _OVER; | ||
| } | ||
|
|
||
| pJson = tjsonParse(curlRsp.data); | ||
| if (pJson == NULL) { | ||
| terrno = TSDB_CODE_INVALID_JSON_FORMAT; | ||
| goto _OVER; | ||
| char *buf = taosMemCalloc(1, curlRsp.dataLen + 1); |
There was a problem hiding this comment.
tjsonCreateObject() and taosMemCalloc() can return NULL if memory allocation fails. The returned pointers pJson and buf are used without being checked, which could lead to a crash. Please add NULL checks after these calls to handle potential memory allocation failures gracefully.
pJson = tjsonCreateObject();
if (pJson == NULL) {
terrno = TSDB_CODE_NO_MEMORY;
goto _EXIT;
}
char *buf = taosMemCalloc(1, curlRsp.dataLen + 1);
if (buf == NULL) {
tjsonDelete(pJson);
pJson = NULL;
terrno = TSDB_CODE_NO_MEMORY;
goto _EXIT;
}| - 最大值：67108864 | ||
| - 动态修改：支持通过 SQL 修改，立即生效 | ||
| - 支持版本：从 v3.3.6.34 版本开始引入 | ||
| - 支持版本：从 v3.3.6.34、v3.3.8.8 版本开始引入 |
There was a problem hiding this comment.
The English version of this documentation (docs/en/14-reference/01-components/02-taosc.md) was updated to change the default value of maxSQLLength from 4,194,304 to 1,048,576. This change is missing in the Chinese documentation on line 338. Please update it for consistency.
10 participants
Description
Issue(s)
Checklist
Please check the items in the checklist if applicable.