From a7d01021fa9f292174b9b08ec6fd03628c379618 Mon Sep 17 00:00:00 2001 From: Andre Nogueira Date: Tue, 26 May 2026 10:55:33 +0100 Subject: [PATCH] fix(make): make release target portable and consistently signed The `release:` target used BSD-style `sed -i ''` for in-place edits, which fails on GNU sed (where `-i` takes an optional suffix and `''` gets consumed as that suffix, leaving the expression treated as a filename). Switched both substitutions to `perl -i -pe`, which behaves identically on macOS and Linux with no temp file. The version-bump commit was also being created without `--signoff` or `--gpg-sign`, even though the matching tag is signed. Aligned the commit invocation with the project's signing convention. Signed-off-by: Andre Nogueira --- Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 68d3683..83b89f3 100644 --- a/Makefile +++ b/Makefile @@ -62,11 +62,11 @@ release: ## Create a release (usage: make release VERSION=1.2.0) exit 1; \ fi @echo "Releasing v$(VERSION)..." - sed -i '' 's/^version = ".*"/version = "$(VERSION)"/' Cargo.toml - sed -i '' 's/^version: ".*"/version: "$(VERSION)"/' deploy/helm/houndr/Chart.yaml + perl -i -pe 's/^version = ".*"/version = "$(VERSION)"/' Cargo.toml + perl -i -pe 's/^version: ".*"/version: "$(VERSION)"/' deploy/helm/houndr/Chart.yaml cargo check git add Cargo.toml Cargo.lock deploy/helm/houndr/Chart.yaml - git commit -m "chore: bump version to $(VERSION)" + git commit --signoff --gpg-sign -m "chore: bump version to $(VERSION)" git tag -s "v$(VERSION)" -m "v$(VERSION)" git push git push origin "v$(VERSION)"