From b475fb39007484512c700121fd80d8db3a1c8d30 Mon Sep 17 00:00:00 2001 From: Arjun Komath Date: Sat, 18 Jan 2025 14:51:35 +1100 Subject: [PATCH] Encode URL parameters in Open Graph URLs --- apps/page/lib/url.ts | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/apps/page/lib/url.ts b/apps/page/lib/url.ts index 996059e..0e0d2ba 100644 --- a/apps/page/lib/url.ts +++ b/apps/page/lib/url.ts @@ -45,14 +45,16 @@ export function getOgUrl( const contentTruncated = content.length > 350 ? content.substring(0, 350) + "..." : content; - return `${pageUrl}/api/og?title=${page?.title}&body=${ - post.title - }&content=${contentTruncated}${ - settings?.page_logo ? "&logo=" + settings?.page_logo : "" - }`; + return `${pageUrl}/api/og?title=${encodeURIComponent( + page?.title + )}&body=${encodeURIComponent(post.title)}&content=${encodeURIComponent( + contentTruncated + )}${settings?.page_logo ? "&logo=" + settings?.page_logo : ""}`; } - return `${pageUrl}/api/og?title=${page?.title}&body=${page.description}${ + return `${pageUrl}/api/og?title=${encodeURIComponent( + page?.title + )}&body=${encodeURIComponent(page.description ?? "")}${ settings?.page_logo ? "&logo=" + settings?.page_logo : "" }`; }