opts/parse_float64_test.go at main · telemachus/opts · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
package opts_test

import (
	"errors"
	"testing"

	"github.com/google/go-cmp/cmp"
	"github.com/telemachus/opts"
)

func TestParseFloat64(t *testing.T) {
	t.Parallel()

	testCases := map[string]struct {
		args []string
		want float64
	}{
		"Integer value; single dash": {
			args: []string{"-x", "42"},
			want: 42.0,
		},
		"Decimal value; single dash": {
			args: []string{"-x", "3.14"},
			want: 3.14,
		},
		"Scientific notation; single dash": {
			args: []string{"-x", "1e-2"},
			want: 0.01,
		},
		"Negative value; single dash": {
			args: []string{"-x", "-3.14"},
			want: -3.14,
		},
		"Space separated decimal; double dash": {
			args: []string{"--value", "3.14"},
			want: 3.14,
		},
		"With equals decimal; double dash": {
			args: []string{"--value=3.14"},
			want: 3.14,
		},
		"Scientific notation; double dash": {
			args: []string{"--value=1e-2"},
			want: 0.01,
		},
		"Integer value; double dash": {
			args: []string{"--value", "42"},
			want: 42.0,
		},
		"Negative value; double dash": {
			args: []string{"--value", "-3.14"},
			want: -3.14,
		},
	}

	for msg, tc := range testCases {
		t.Run(msg, func(t *testing.T) {
			t.Parallel()

			var got float64
			og := opts.NewGroup("test-parsing")
			og.Float64(&got, "x", 0.0)
			og.Float64(&got, "value", 0.0)

			err := og.Parse(tc.args)
			if err != nil {
				t.Fatalf("og.Parse(%v) returns %v as err; want nil", tc.args, err)
			}

			if got != tc.want {
				t.Errorf("og.Parse(%v) assigns %g to got; want %g", tc.args, got, tc.want)
			}
		})
	}
}

func TestParseFloat64WithRemainingArgs(t *testing.T) {
	t.Parallel()

	testCases := map[string]struct {
		args     []string
		postArgs []string
		want     float64
	}{
		"Args after value; single dash": {
			args:     []string{"-x", "3.14", "foo", "bar"},
			postArgs: []string{"foo", "bar"},
			want:     3.14,
		},
		"Args after value; double dash": {
			args:     []string{"--value", "3.14", "foo", "bar"},
			postArgs: []string{"foo", "bar"},
			want:     3.14,
		},
	}

	for msg, tc := range testCases {
		t.Run(msg, func(t *testing.T) {
			t.Parallel()

			var got float64
			og := opts.NewGroup("test-parsing")
			og.Float64(&got, "x", 0.0)
			og.Float64(&got, "value", 0.0)

			remaining, err := og.ParseKnown(tc.args)
			if err != nil {
				t.Fatalf("og.ParseKnown(%v) returns %v as err; want nil", tc.args, err)
			}

			if got != tc.want {
				t.Errorf("og.ParseKnown(%v) assigns %g to got; want %g", tc.args, got, tc.want)
			}

			if diff := cmp.Diff(tc.postArgs, remaining); diff != "" {
				t.Errorf("og.ParseKnown(%v); (-want +got):\n%s", tc.args, diff)
			}
		})
	}
}

func TestParseFloat64ErrMissingValue(t *testing.T) {
	t.Parallel()

	testCases := map[string]struct {
		errWanted error
		args      []string
	}{
		"Single dash, no value": {
			args:      []string{"-x"},
			errWanted: opts.ErrMissingValue,
		},
		"Double dash, no value": {
			args:      []string{"--value"},
			errWanted: opts.ErrMissingValue,
		},
		"Double dash, equals no value": {
			args:      []string{"--value="},
			errWanted: opts.ErrMissingValue,
		},
	}

	for msg, tc := range testCases {
		t.Run(msg, func(t *testing.T) {
			t.Parallel()

			var got float64
			og := opts.NewGroup("test-parsing")
			og.Float64(&got, "x", 0.0)
			og.Float64(&got, "value", 0.0)

			err := og.Parse(tc.args)
			if !errors.Is(err, opts.ErrMissingValue) {
				t.Fatalf("og.Parse(%v) returns %v as err; want %v", tc.args, err, opts.ErrMissingValue)
			}
		})
	}
}

func TestParseFloat64InvalidValueError(t *testing.T) {
	t.Parallel()

	testCases := map[string]struct {
		args []string
	}{
		"Single dash, invalid value": {
			args: []string{"-x", "xyz"},
		},
		"Double dash, invalid value": {
			args: []string{"--value", "xyz"},
		},
		"Double dash, equals invalid": {
			args: []string{"--value=xyz"},
		},
		"Double dash, invalid scientific": {
			args: []string{"--value=1e"},
		},
		"Double dash, multiple equals": {
			args: []string{"--value=3.14=2.718"},
		},
	}

	for msg, tc := range testCases {
		t.Run(msg, func(t *testing.T) {
			t.Parallel()

			var got float64
			og := opts.NewGroup("test-parsing")
			og.Float64(&got, "x", 0.0)
			og.Float64(&got, "value", 0.0)

			err := og.Parse(tc.args)
			var ive *opts.InvalidValueError

			if !errors.As(err, &ive) {
				t.Fatalf("og.Parse(%v) returns %T; want *opts.InvalidValueError", tc.args, err)
			}
		})
	}
}