Mvisor failed to compile

[einhander]

Hello!

I use Debian Testing. I tried to compile the mvisor but without luck. Here the error log:

[89/182] Compiling C++ object mvisor.p/devices_agents_spice_agent.cc.o
FAILED: mvisor.p/devices_agents_spice_agent.cc.o 
c++ -Imvisor.p -I. -I.. -I../include -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -I/usr/include/pixman-1 -I/usr/include/virgl -I/usr/include/SDL2 -fdiagnostics-color=always -D_GLIBCXX_ASSERTIONS=1 -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c++17 -O2 -g -Wno-address-of-packed-member -Wno-missing-field-initializers -mavx2 -D_REENTRANT -pthread -MD -MQ mvisor.p/devices_agents_spice_agent.cc.o -MF mvisor.p/devices_agents_spice_agent.cc.o.d -o mvisor.p/devices_agents_spice_agent.cc.o -c ../devices/agents/spice_agent.cc
In file included from ../devices/agents/spice_agent.cc:29:
../devices/agents/serial_port.h:11:16: error: ‘virtual void SerialPort::SendMessage(uint8_t*, size_t)’ was hidden [-Werror=overloaded-virtual=]
   11 |   virtual void SendMessage(uint8_t* data, size_t size);
      |                ^~~~~~~~~~~
../devices/agents/spice_agent.cc:161:8: note:   by ‘void SpiceAgent::SendMessage(int, const std::string&)’
  161 |   void SendMessage(int port, const std::string& message) {
      |        ^~~~~~~~~~~
cc1plus: all warnings being treated as errors
[98/182] Compiling C++ object mvisor.p/devices_ahci_ata_disk.cc.o
ninja: build stopped: subcommand failed.

[78]

Try to rename this function SendMessage in ../devices/agents/spice_agent.cc:161 and build again.

[einhander]

@78 still no luck

[5/74] Compiling C++ object mvisor.p/devices_agents_spice_agent.cc.o
FAILED: mvisor.p/devices_agents_spice_agent.cc.o 
c++ -Imvisor.p -I. -I.. -I../include -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -I/usr/include/pixman-1 -I/usr/include/virgl -I/usr/include/SDL2 -fdiagnostics-color=always -D_GLIBCXX_ASSERTIONS=1 -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c++17 -O2 -g -Wno-address-of-packed-member -Wno-missing-field-initializers -mavx2 -D_REENTRANT -pthread -MD -MQ mvisor.p/devices_agents_spice_agent.cc.o -MF mvisor.p/devices_agents_spice_agent.cc.o.d -o mvisor.p/devices_agents_spice_agent.cc.o -c ../devices/agents/spice_agent.cc
../devices/agents/spice_agent.cc: In member function ‘void SpiceAgent::SendAgentMessage(int, int, void*, size_t)’:
../devices/agents/spice_agent.cc:192:23: error: cannot convert ‘std::string’ {aka ‘std::__cxx11::basic_string<char>’} to ‘size_t’ {aka ‘long unsigned int’}
  192 |     SendMessage(port, outgoing_message);
      |                       ^~~~~~~~~~~~~~~~
      |                       |
      |                       std::string {aka std::__cxx11::basic_string<char>}
In file included from ../devices/agents/spice_agent.cc:29:
../devices/agents/serial_port.h:11:50: note: initializing argument 2 of ‘virtual void SerialPort::SendMessage(uint8_t*, size_t)’
   11 |   virtual void SendMessage(uint8_t* data, size_t size);
      |                                           ~~~~~~~^~~~
[14/74] Compiling C object mvisor.p/devices_display_qxl_canvas_rop3.c.o
ninja: build stopped: subcommand failed.

[78]

Do you have VSCode? You can ask Copilot Chat for help to solve this compilation issue.

[einhander]

@78, You are right an AI helped me to solve this issue. Here is the diff:

diff --git a/devices/agents/spice_agent.cc b/devices/agents/spice_agent.cc
index 86c005f..8863bf1 100644
--- a/devices/agents/spice_agent.cc
+++ b/devices/agents/spice_agent.cc
@@ -51,6 +51,7 @@ class SpiceAgent : public Device, public SerialPort,
   uint32_t                        max_clipboard_ = 1024 * 1024;
 
  public:
+  using SerialPort::SendMessage;  // <-- ДОБАВЬТЕ ЭТУ СТРОКУ
   SpiceAgent() {
     set_default_parent_class("VirtioConsole");