Skip to content

Review tests without sync/async counterparts #92

@teremterem

Description

@teremterem

Parent: #90

Context

Several tests exist only in the sync or async variant with no direct counterpart. Some of these are intentionally different; others may benefit from having a counterpart added.

Tests to review

File Test(s) Notes
test_call_overrides_sync.py test_config_params_work_with_sync_functions Combined smoke test; async tests each param individually
test_call_overrides_async.py 9 individual param tests, test_config_kwargs_alongside_function_kwargs, test_call_override_with_inherit, test_call_override_with_global_default No sync counterparts
test_function_decorator_sync.py test_sync_function_runs_in_different_thread Inherently sync-only
test_function_decorator_async.py test_function_decorator_with_empty_parens Async-only (sync needs explicit use_thread_pool=True)
test_method_function_decorator_async.py 4 empty-parens tests Async-only
test_await_children_sync.py test_await_children_sync_recursively_all_sync, test_await_children_sync_raises_on_event_loop_thread Sync-specific scenarios
test_await_children_async.py test_await_children_recursively_sync_children Async root + sync children
test_promise_as_future_sync.py test_concurrent_consumers_with_timeout Thread-based concurrent access
test_promise_as_future_async.py test_concurrent_consumers Asyncio task-based concurrent awaiting
test_nesting_sync.py / test_nesting_async.py Promising context tests differ Sync can't separate call-site from execution
test_parent_resolution.py Entire file Has a TODO to expand into sync/async pairs

Action items

  • For each test, decide: add a counterpart, document why it's intentionally solo, or leave as-is
  • Address the TODO in test_parent_resolution.py

🤖 Generated with Claude Code

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions