Skip to content

feat(players): overlay skill history on ELO chart#592

Open
garrappachc wants to merge 2 commits into
masterfrom
feat/elo-chart-skill-overlay
Open

feat(players): overlay skill history on ELO chart#592
garrappachc wants to merge 2 commits into
masterfrom
feat/elo-chart-skill-overlay

Conversation

@garrappachc
Copy link
Copy Markdown
Member

@garrappachc garrappachc commented May 6, 2026

Summary

  • Adds a skill layer on top of the ELO history chart so admins can correlate ELO changes with manual skill adjustments
  • Skill is rendered as a dashed white stepped line on a right-side Y-axis, aligned to existing ELO data points
  • The overlay only appears when the selected class has admin-set skill history; charts for players without skill data are unchanged

How it works

For each ELO data point, buildSkillData finds the most recent skillHistory entry whose at date is ≤ the game date, producing a parallel array of number | null. This gives a step-function that stays flat between admin changes and jumps when skill is updated.

Test plan

  • Open a player profile with skill history set — verify the dashed skill line appears on the ELO chart with a right-side axis
  • Switch between class tabs — verify skill line updates correctly per class
  • Switch between "Over time" / "By game #" modes — verify both axes render correctly
  • Open a player profile with no skill history — verify chart looks identical to before (no second axis, no legend)

🤖 Generated with Claude Code

garrappachc and others added 2 commits May 6, 2026 10:37
@garrappachc @claude
feat(players): overlay skill history on ELO chart
782c257 
Adds a second dataset to the ELO history chart that shows the player's
admin-set skill value over time, aligned with ELO data points. The skill
line uses a dashed stepped style on a right-side Y-axis so ELO and skill
changes can be correlated visually. The overlay is only rendered when
skill history exists for the selected class.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@garrappachc
lint
e9ae9b9
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026 •
edited
Loading

Playwright test results

passed  199 passed

Details

stats  199 tests across 29 suites
duration  10 minutes, 45 seconds
commit  e9ae9b9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@garrappachc